BUG/MINOR: config: fix leak on proxy.conn_src.bind_hdr_name

Leak for parsing of option usesrc of the source keyword.

This can be backported to 1.8.

diff --git a/src/cfgparse-listen.c b/src/cfgparse-listen.c
index 588ff9704ac846dc992ddb9daafb30beeb9586f4..689a28eb3d0a9f2ce58da958a5b0c569d8cfe3c8 100644 (file)
--- a/src/cfgparse-listen.c
+++ b/src/cfgparse-listen.c
@@ -2915,6 +2915,7 @@ stats_error_parsing:
 
                                        curproxy->conn_src.opts &= ~CO_SRC_TPROXY_MASK;
                                        curproxy->conn_src.opts |= CO_SRC_TPROXY_DYN;
+                                       free(curproxy->conn_src.bind_hdr_name);
                                        curproxy->conn_src.bind_hdr_name = calloc(1, end - name + 1);
                                        curproxy->conn_src.bind_hdr_len = end - name;
                                        memcpy(curproxy->conn_src.bind_hdr_name, name, end - name);

diff --git a/src/haproxy.c b/src/haproxy.c
index e36e020c5ce771a6d891feb7e117ecb10f487385..cdbc3dc96b1934b12b3573b267b15273f218102a 100644 (file)
--- a/src/haproxy.c
+++ b/src/haproxy.c
@@ -2503,6 +2503,9 @@ void deinit(void)
                free(p->rdp_cookie_name);
                free(p->invalid_rep);
                free(p->invalid_req);
+#if defined(CONFIG_HAP_TRANSPARENT)
+               free(p->conn_src.bind_hdr_name);
+#endif
                if (p->conf.logformat_string != default_http_log_format &&
                    p->conf.logformat_string != default_tcp_log_format &&
                    p->conf.logformat_string != clf_http_log_format)