ext4: introduce ITAIL helper

Introduce ITAIL helper to get the bound of xattr in inode.

Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20250208063141.1539283-2-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index f777713c9ddb4d0bf895b8f877ef0ed5da7a05c2..06195df911afb31672a33d71a865f240f1e17f92 100644 (file)
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -649,7 +649,7 @@ ext4_xattr_ibody_get(struct inode *inode, int name_index, const char *name,
                return error;
        raw_inode = ext4_raw_inode(&iloc);
        header = IHDR(inode, raw_inode);
-       end = (void *)raw_inode + EXT4_SB(inode->i_sb)->s_inode_size;
+       end = ITAIL(inode, raw_inode);
        error = xattr_check_inode(inode, header, end);
        if (error)
                goto cleanup;
@@ -793,7 +793,7 @@ ext4_xattr_ibody_list(struct dentry *dentry, char *buffer, size_t buffer_size)
                return error;
        raw_inode = ext4_raw_inode(&iloc);
        header = IHDR(inode, raw_inode);
-       end = (void *)raw_inode + EXT4_SB(inode->i_sb)->s_inode_size;
+       end = ITAIL(inode, raw_inode);
        error = xattr_check_inode(inode, header, end);
        if (error)
                goto cleanup;
@@ -879,7 +879,7 @@ int ext4_get_inode_usage(struct inode *inode, qsize_t *usage)
                        goto out;
                raw_inode = ext4_raw_inode(&iloc);
                header = IHDR(inode, raw_inode);
-               end = (void *)raw_inode + EXT4_SB(inode->i_sb)->s_inode_size;
+               end = ITAIL(inode, raw_inode);
                ret = xattr_check_inode(inode, header, end);
                if (ret)
                        goto out;
@@ -2244,7 +2244,7 @@ int ext4_xattr_ibody_find(struct inode *inode, struct ext4_xattr_info *i,
        header = IHDR(inode, raw_inode);
        is->s.base = is->s.first = IFIRST(header);
        is->s.here = is->s.first;
-       is->s.end = (void *)raw_inode + EXT4_SB(inode->i_sb)->s_inode_size;
+       is->s.end = ITAIL(inode, raw_inode);
        if (ext4_test_inode_state(inode, EXT4_STATE_XATTR)) {
                error = xattr_check_inode(inode, header, is->s.end);
                if (error)
@@ -2795,7 +2795,7 @@ retry:
         */
 
        base = IFIRST(header);
-       end = (void *)raw_inode + EXT4_SB(inode->i_sb)->s_inode_size;
+       end = ITAIL(inode, raw_inode);
        min_offs = end - base;
        total_ino = sizeof(struct ext4_xattr_ibody_header) + sizeof(u32);
 

diff --git a/fs/ext4/xattr.h b/fs/ext4/xattr.h
index b25c2d7b5f991563881e945d8e5e0d2030551790..5197f17ffd9a2e09c1ddcca341aca63b60319d4a 100644 (file)
--- a/fs/ext4/xattr.h
+++ b/fs/ext4/xattr.h
@@ -67,6 +67,9 @@ struct ext4_xattr_entry {
                ((void *)raw_inode + \
                EXT4_GOOD_OLD_INODE_SIZE + \
                EXT4_I(inode)->i_extra_isize))
+#define ITAIL(inode, raw_inode) \
+       ((void *)(raw_inode) + \
+        EXT4_SB((inode)->i_sb)->s_inode_size)
 #define IFIRST(hdr) ((struct ext4_xattr_entry *)((hdr)+1))
 
 /*