lib/fields.c: valid_field(): Remove useless check

We only call this function with a string literal, and it makes little
sense to pass something else.  Let's simplify.

Signed-off-by: Alejandro Colomar <alx@kernel.org>

diff --git a/lib/fields.c b/lib/fields.c
index d30ed698ab76fa0ef7757e7cb4e38986315d4ac1..818d1c593b84280f12d47634748638354b181110 100644 (file)
--- a/lib/fields.c
+++ b/lib/fields.c
@@ -42,11 +42,8 @@ valid_field_(const char *field, const char *illegal)
                return -1;
        }
 
-       /* For each character of field, search if it appears in the list
-        * of illegal characters. */
-       if (illegal && strpbrk(field, illegal)) {
+       if (strpbrk(field, illegal))
                return -1;
-       }
 
        /* Search if there are non-printable or control characters */
        for (cp = field; !streq(cp, ""); cp++) {