iptables: warn when parameter limit is exceeded

While testing many match extensions in a single rule, I ran into this
error not warned about. Arguments were just ignored, causing
surprising "Need to specify an argument to --whatever" when the
argument was in fact given on the command line.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>

diff --git a/ip6tables-restore.c b/ip6tables-restore.c
index cea5f36e95bdc718f5c120c94ae56702662d79b2..9948cd63478dfb30a5cf242f08d8d59da3e19a6f 100644 (file)
--- a/ip6tables-restore.c
+++ b/ip6tables-restore.c
@@ -103,8 +103,11 @@ static int add_argv(char *what) {
                newargv[newargc] = strdup(what);
                newargc++;
                return 1;
-       } else
+       } else {
+               xtables_error(PARAMETER_PROBLEM,
+                       "Parser cannot handle more arguments\n");
                return 0;
+       }
 }
 
 static void free_argv(void) {

diff --git a/iptables-restore.c b/iptables-restore.c
index bf80e788913944e42a7c51a14257c45fa975e070..519d480051030058e5bc6a24de1d341395bab001 100644 (file)
--- a/iptables-restore.c
+++ b/iptables-restore.c
@@ -103,8 +103,11 @@ static int add_argv(char *what) {
                newargv[newargc] = strdup(what);
                newargc++;
                return 1;
-       } else 
+       } else {
+               xtables_error(PARAMETER_PROBLEM,
+                       "Parser cannot handle more arguments\n");
                return 0;
+       }
 }
 
 static void free_argv(void) {