]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: zforce_ts - remove assert/deassert wrappers
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 24 Aug 2024 05:50:41 +0000 (22:50 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 6 Sep 2024 05:56:47 +0000 (22:56 -0700)
The wrappers are extremely simple, used once, and do not bring much
value. Remove them.

Tested-by: Andreas Kemnade <andreas@kemnade.info> # Tolino Shine2HD
Link: https://lore.kernel.org/r/20240824055047.1706392-18-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/zforce_ts.c

index 116f3aa6350c1670b60e29bd569218721de0e96e..5df4f9e8fb2ed425df13f63cb83de2beab20159b 100644 (file)
@@ -146,16 +146,6 @@ static int zforce_command(struct zforce_ts *ts, u8 cmd)
        return 0;
 }
 
-static void zforce_reset_assert(struct zforce_ts *ts)
-{
-       gpiod_set_value_cansleep(ts->gpio_rst, 1);
-}
-
-static void zforce_reset_deassert(struct zforce_ts *ts)
-{
-       gpiod_set_value_cansleep(ts->gpio_rst, 0);
-}
-
 static int zforce_send_wait(struct zforce_ts *ts, const char *buf, int len)
 {
        struct i2c_client *client = ts->client;
@@ -672,7 +662,7 @@ static void zforce_reset(void *data)
 {
        struct zforce_ts *ts = data;
 
-       zforce_reset_assert(ts);
+       gpiod_set_value_cansleep(ts->gpio_rst, 1);
        udelay(10);
 }
 
@@ -807,7 +797,7 @@ static int zforce_probe(struct i2c_client *client)
        i2c_set_clientdata(client, ts);
 
        /* let the controller boot */
-       zforce_reset_deassert(ts);
+       gpiod_set_value_cansleep(ts->gpio_rst, 0);
 
        ts->command_waiting = NOTIFICATION_BOOTCOMPLETE;
        if (wait_for_completion_timeout(&ts->command_done, WAIT_TIMEOUT) == 0)