]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
s390/tape: Switch over to sysfs_emit()
authorMete Durlu <meted@linux.ibm.com>
Wed, 23 Oct 2024 12:11:09 +0000 (14:11 +0200)
committerHeiko Carstens <hca@linux.ibm.com>
Fri, 25 Oct 2024 14:03:25 +0000 (16:03 +0200)
Per Documentation/filesystems/sysfs.rst, sysfs_emit() is preferred for
presenting attributes to user space in sysfs. Convert the left-over uses
in the char/tape_core code.

Signed-off-by: Mete Durlu <meted@linux.ibm.com>
Reviewed-by: Jan Höppner <hoeppner@linux.ibm.com>
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
drivers/s390/char/tape_core.c

index a6d2a4792185096f833f2b1eba79eb705a7561bc..ce8a440598a814c35d738cbd58a5a33309fc73f0 100644 (file)
@@ -96,7 +96,7 @@ tape_medium_state_show(struct device *dev, struct device_attribute *attr, char *
        struct tape_device *tdev;
 
        tdev = dev_get_drvdata(dev);
-       return scnprintf(buf, PAGE_SIZE, "%i\n", tdev->medium_state);
+       return sysfs_emit(buf, "%i\n", tdev->medium_state);
 }
 
 static
@@ -108,7 +108,7 @@ tape_first_minor_show(struct device *dev, struct device_attribute *attr, char *b
        struct tape_device *tdev;
 
        tdev = dev_get_drvdata(dev);
-       return scnprintf(buf, PAGE_SIZE, "%i\n", tdev->first_minor);
+       return sysfs_emit(buf, "%i\n", tdev->first_minor);
 }
 
 static
@@ -120,8 +120,8 @@ tape_state_show(struct device *dev, struct device_attribute *attr, char *buf)
        struct tape_device *tdev;
 
        tdev = dev_get_drvdata(dev);
-       return scnprintf(buf, PAGE_SIZE, "%s\n", (tdev->first_minor < 0) ?
-               "OFFLINE" : tape_state_verbose[tdev->tape_state]);
+       return sysfs_emit(buf, "%s\n", (tdev->first_minor < 0) ?
+                         "OFFLINE" : tape_state_verbose[tdev->tape_state]);
 }
 
 static
@@ -135,17 +135,17 @@ tape_operation_show(struct device *dev, struct device_attribute *attr, char *buf
 
        tdev = dev_get_drvdata(dev);
        if (tdev->first_minor < 0)
-               return scnprintf(buf, PAGE_SIZE, "N/A\n");
+               return sysfs_emit(buf, "N/A\n");
 
        spin_lock_irq(get_ccwdev_lock(tdev->cdev));
        if (list_empty(&tdev->req_queue))
-               rc = scnprintf(buf, PAGE_SIZE, "---\n");
+               rc = sysfs_emit(buf, "---\n");
        else {
                struct tape_request *req;
 
                req = list_entry(tdev->req_queue.next, struct tape_request,
                        list);
-               rc = scnprintf(buf,PAGE_SIZE, "%s\n", tape_op_verbose[req->op]);
+               rc = sysfs_emit(buf, "%s\n", tape_op_verbose[req->op]);
        }
        spin_unlock_irq(get_ccwdev_lock(tdev->cdev));
        return rc;
@@ -161,7 +161,7 @@ tape_blocksize_show(struct device *dev, struct device_attribute *attr, char *buf
 
        tdev = dev_get_drvdata(dev);
 
-       return scnprintf(buf, PAGE_SIZE, "%i\n", tdev->char_data.block_size);
+       return sysfs_emit(buf, "%i\n", tdev->char_data.block_size);
 }
 
 static