]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
libstdc++: allow string_view insertion to work with <iosfwd> (PR 94051)
authorJonathan Wakely <jwakely@redhat.com>
Thu, 5 Mar 2020 16:46:28 +0000 (16:46 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Thu, 5 Mar 2020 16:46:28 +0000 (16:46 +0000)
I don't think this is actually required to compile, because using
operator<< without a definition of the ostream doesn't seem valid to me.
But it's easy to make it work.

PR libstdc++/94051
* include/std/string_view: Include <bits/ostream_insert.h>.
* testsuite/21_strings/basic_string_view/inserters/94051.cc: New test.

libstdc++-v3/ChangeLog
libstdc++-v3/include/std/string_view
libstdc++-v3/testsuite/21_strings/basic_string_view/inserters/94051.cc [new file with mode: 0644]

index df3b040abca38948e4ace90cc8afe2f8275785e5..fd4d502badd6febb2ce4b3d7a9df5e89512979e4 100644 (file)
@@ -1,3 +1,9 @@
+2020-03-05  Jonathan Wakely  <jwakely@redhat.com>
+
+       PR libstdc++/94051
+       * include/std/string_view: Include <bits/ostream_insert.h>.
+       * testsuite/21_strings/basic_string_view/inserters/94051.cc: New test.
+
 2020-03-04  Jonathan Wakely  <jwakely@redhat.com>
 
        * include/bits/cpp_type_traits.h (__memcpyable): Fix comment.
index ea5d547e00603c499884ec1fa412e588481d9dd6..99a81bb04facdcf4cdc28dea88396225f0d7febb 100644 (file)
@@ -42,6 +42,7 @@
 #include <bits/functional_hash.h>
 #include <bits/int_limits.h>
 #include <bits/range_access.h>
+#include <bits/ostream_insert.h>
 
 namespace std _GLIBCXX_VISIBILITY(default)
 {
diff --git a/libstdc++-v3/testsuite/21_strings/basic_string_view/inserters/94051.cc b/libstdc++-v3/testsuite/21_strings/basic_string_view/inserters/94051.cc
new file mode 100644 (file)
index 0000000..3266691
--- /dev/null
@@ -0,0 +1,28 @@
+// Copyright (C) 2020 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++17" }
+// { dg-do compile { target c++17 } }
+
+#include <iosfwd>
+#include <string_view>
+
+void
+test01(std::ostream& os, std::string_view sv)
+{
+  os << sv;
+}