]> git.ipfire.org Git - thirdparty/git.git/commitdiff
tests: fix a memory leak in test-prio-queue.c
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Thu, 7 Oct 2021 10:01:31 +0000 (12:01 +0200)
committerJunio C Hamano <gitster@pobox.com>
Thu, 7 Oct 2021 22:40:15 +0000 (15:40 -0700)
Fix a memory leak in t/helper/test-prio-queue.c, the lack of freeing
the memory with clear_prio_queue() has been there ever since this code
was originally added in b4b594a3154 (prio-queue: priority queue of
pointers to structs, 2013-06-06).

By fixing this leak we can cleanly run t0009-prio-queue.sh under
SANITIZE=leak, so annotate it as such with
TEST_PASSES_SANITIZE_LEAK=true.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/helper/test-prio-queue.c
t/t0009-prio-queue.sh

index f4028442e37e39d7ec35abf00c237d4d2cbac892..133b5e6f4ae5fdbd90f6594223df60f918a036f4 100644 (file)
@@ -46,5 +46,7 @@ int cmd__prio_queue(int argc, const char **argv)
                }
        }
 
+       clear_prio_queue(&pq);
+
        return 0;
 }
index 3941ad25286562a57faa63d4ba37604d1fd708bd..eea99107a488dcf5d14bbc42cb4222abf0c8cb2c 100755 (executable)
@@ -1,6 +1,8 @@
 #!/bin/sh
 
 test_description='basic tests for priority queue implementation'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 cat >expect <<'EOF'