]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
RDMA/mana: Fix error unwind in mana_ib_create_qp_rss()
authorJason Gunthorpe <jgg@nvidia.com>
Tue, 28 Apr 2026 16:17:40 +0000 (13:17 -0300)
committerJason Gunthorpe <jgg@nvidia.com>
Sat, 2 May 2026 18:30:48 +0000 (15:30 -0300)
Sashiko points out that mana_ib_cfg_vport_steering() is leaked, the normal
destroy path cleans it up.

Cc: stable@vger.kernel.org
Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
Link: https://sashiko.dev/#/patchset/0-v1-e911b76a94d1%2B65d95-rdma_udata_rep_jgg%40nvidia.com?part=4
Link: https://patch.msgid.link/r/7-v1-41f3135e5565+9d2-rdma_ai_fixes1_jgg@nvidia.com
Reviewed-by: Long Li <longli@microsoft.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/mana/qp.c

index 8e1f052d0ec976f2ecf7991774135d4dba234662..0fbcf449c134b5389a47dee192645f1c5de2b333 100644 (file)
@@ -217,13 +217,15 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp, struct ib_pd *pd,
                ibdev_dbg(&mdev->ib_dev,
                          "Failed to copy to udata create rss-qp, %d\n",
                          ret);
-               goto fail;
+               goto err_disable_vport_rx;
        }
 
        kfree(mana_ind_table);
 
        return 0;
 
+err_disable_vport_rx:
+       mana_disable_vport_rx(mpc);
 fail:
        while (i-- > 0) {
                ibwq = ind_tbl->ind_tbl[i];