]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86/amd/pmc: Use managed APIs for mutex
authorShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Wed, 5 Mar 2025 14:26:15 +0000 (19:56 +0530)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 7 Mar 2025 10:17:51 +0000 (12:17 +0200)
Adopt managed devm_* APIs for handling mutex creation and deletion,
facilitating automatic resource cleanup.

Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20250305142615.410178-4-Shyam-sundar.S-k@amd.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/amd/pmc/pmc.c

index 1ad3eb9354048e6ee958f9400d2a2fa39d2cd716..84bc47009e5f94e1cf1af80cef4686a4fa8bd62b 100644 (file)
@@ -783,7 +783,9 @@ static int amd_pmc_probe(struct platform_device *pdev)
                goto err_pci_dev_put;
        }
 
-       mutex_init(&dev->lock);
+       err = devm_mutex_init(dev->dev, &dev->lock);
+       if (err)
+               return err;
 
        /* Get num of IP blocks within the SoC */
        amd_pmc_get_ip_info(dev);
@@ -822,7 +824,6 @@ static void amd_pmc_remove(struct platform_device *pdev)
        pci_dev_put(dev->rdev);
        if (IS_ENABLED(CONFIG_AMD_MP2_STB))
                amd_mp2_stb_deinit(dev);
-       mutex_destroy(&dev->lock);
 }
 
 static const struct acpi_device_id amd_pmc_acpi_ids[] = {