]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
seq_file: Mark binary printing functions with __printf() attribute
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 21 Mar 2025 14:40:48 +0000 (16:40 +0200)
committerPetr Mladek <pmladek@suse.com>
Fri, 28 Mar 2025 12:37:11 +0000 (13:37 +0100)
Binary printing functions are using printf() type of format, and compiler
is not happy about them as is:

fs/seq_file.c:418:35: error: function ‘seq_bprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]

Fix the compilation errors by adding __printf() attribute.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Kees Cook <kees@kernel.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20250321144822.324050-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Petr Mladek <pmladek@suse.com>
include/linux/seq_file.h

index 2fb266ea69fa4dbbd2536d225461b7fbb5c6c5fe..d6ebf0596510c986f14c1fe5fd912776fde44344 100644 (file)
@@ -181,6 +181,7 @@ int seq_open_private(struct file *, const struct seq_operations *, int);
 int seq_release_private(struct inode *, struct file *);
 
 #ifdef CONFIG_BINARY_PRINTF
+__printf(2, 0)
 void seq_bprintf(struct seq_file *m, const char *f, const u32 *binary);
 #endif