]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
xfs: use XFS_BUF_DADDR_NULL for daddrs in getfsmap code
authorDarrick J. Wong <djwong@kernel.org>
Fri, 23 Aug 2024 00:00:20 +0000 (17:00 -0700)
committerChandan Babu R <chandanbabu@kernel.org>
Tue, 27 Aug 2024 13:02:08 +0000 (18:32 +0530)
Use XFS_BUF_DADDR_NULL (instead of a magic sentinel value) to mean "this
field is null" like the rest of xfs.

Cc: wozizhi@huawei.com
Fixes: e89c041338ed6 ("xfs: implement the GETFSMAP ioctl")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
fs/xfs/xfs_fsmap.c

index 3a30b36779db56f62efe58a77e4dc98f0f992520..613a0ec20412099be672bbb15e0fbae345b76b0a 100644 (file)
@@ -252,7 +252,7 @@ xfs_getfsmap_rec_before_start(
        const struct xfs_rmap_irec      *rec,
        xfs_daddr_t                     rec_daddr)
 {
-       if (info->low_daddr != -1ULL)
+       if (info->low_daddr != XFS_BUF_DADDR_NULL)
                return rec_daddr < info->low_daddr;
        if (info->low.rm_blockcount)
                return xfs_rmap_compare(rec, &info->low) < 0;
@@ -983,7 +983,7 @@ xfs_getfsmap(
                info.dev = handlers[i].dev;
                info.last = false;
                info.pag = NULL;
-               info.low_daddr = -1ULL;
+               info.low_daddr = XFS_BUF_DADDR_NULL;
                info.low.rm_blockcount = 0;
                error = handlers[i].fn(tp, dkeys, &info);
                if (error)