]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
platform/x86: x86-android-tablets: Simplify lenovo_yoga_tab2_830_1050_exit()
authorHans de Goede <hansg@kernel.org>
Sat, 20 Sep 2025 20:07:11 +0000 (22:07 +0200)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 26 Sep 2025 11:26:40 +0000 (14:26 +0300)
lenovo_yoga_tab2_830_1050_exit() only gets called after a successful
lenovo_yoga_tab2_830_1050_init() call so there is no need to check
if lenovo_yoga_tab2_830_1050_codec_[dev|pinctrl] are set.

Also change the exit() order to be the exact reverse of init().

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hansg@kernel.org>
Link: https://patch.msgid.link/20250920200713.20193-19-hansg@kernel.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/x86-android-tablets/lenovo.c

index 832be02495b57c8af3cfb46bd32ceba6282655de..08cabaa5e0c0d8d48b6f3c75bb32f0775e2a084f 100644 (file)
@@ -594,15 +594,10 @@ static void lenovo_yoga_tab2_830_1050_exit(void)
 {
        unregister_sys_off_handler(lenovo_yoga_tab2_830_1050_sys_off_handler);
 
-       if (lenovo_yoga_tab2_830_1050_codec_dev) {
-               device_remove_software_node(lenovo_yoga_tab2_830_1050_codec_dev);
-               put_device(lenovo_yoga_tab2_830_1050_codec_dev);
-       }
-
-       if (lenovo_yoga_tab2_830_1050_codec_pinctrl) {
-               pinctrl_put(lenovo_yoga_tab2_830_1050_codec_pinctrl);
-               pinctrl_unregister_mappings(&lenovo_yoga_tab2_830_1050_codec_pinctrl_map);
-       }
+       device_remove_software_node(lenovo_yoga_tab2_830_1050_codec_dev);
+       pinctrl_put(lenovo_yoga_tab2_830_1050_codec_pinctrl);
+       pinctrl_unregister_mappings(&lenovo_yoga_tab2_830_1050_codec_pinctrl_map);
+       put_device(lenovo_yoga_tab2_830_1050_codec_dev);
 }
 
 /*