]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Sep 2021 12:08:14 +0000 (14:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Sep 2021 12:08:14 +0000 (14:08 +0200)
added patches:
alsa-usb-audio-add-registration-quirk-for-jbl-quantum-800.patch
pci-call-max-payload-size-related-fixup-quirks-early.patch
usb-host-xhci-rcar-don-t-reload-firmware-after-the-completion.patch
usb-mtu3-fix-the-wrong-hs-mult-value.patch
usb-mtu3-use-mult-for-hs-isoc-or-intr.patch
x86-reboot-limit-dell-optiplex-990-quirk-to-early-bios-versions.patch
xhci-fix-unsafe-memory-usage-in-xhci-tracing.patch

queue-5.4/alsa-usb-audio-add-registration-quirk-for-jbl-quantum-800.patch [new file with mode: 0644]
queue-5.4/pci-call-max-payload-size-related-fixup-quirks-early.patch [new file with mode: 0644]
queue-5.4/series
queue-5.4/usb-host-xhci-rcar-don-t-reload-firmware-after-the-completion.patch [new file with mode: 0644]
queue-5.4/usb-mtu3-fix-the-wrong-hs-mult-value.patch [new file with mode: 0644]
queue-5.4/usb-mtu3-use-mult-for-hs-isoc-or-intr.patch [new file with mode: 0644]
queue-5.4/x86-reboot-limit-dell-optiplex-990-quirk-to-early-bios-versions.patch [new file with mode: 0644]
queue-5.4/xhci-fix-unsafe-memory-usage-in-xhci-tracing.patch [new file with mode: 0644]

diff --git a/queue-5.4/alsa-usb-audio-add-registration-quirk-for-jbl-quantum-800.patch b/queue-5.4/alsa-usb-audio-add-registration-quirk-for-jbl-quantum-800.patch
new file mode 100644 (file)
index 0000000..aa1abd0
--- /dev/null
@@ -0,0 +1,31 @@
+From c8b177b6e3a005bd8fb0395a4bc5db3470301c28 Mon Sep 17 00:00:00 2001
+From: Alexander Tsoy <alexander@tsoy.me>
+Date: Tue, 31 Aug 2021 03:25:31 +0300
+Subject: ALSA: usb-audio: Add registration quirk for JBL Quantum 800
+
+From: Alexander Tsoy <alexander@tsoy.me>
+
+commit c8b177b6e3a005bd8fb0395a4bc5db3470301c28 upstream.
+
+Add another device ID for JBL Quantum 800. It requires the same quirk as
+other JBL Quantum devices.
+
+Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
+Cc: <stable@vger.kernel.org>
+Link: https://lore.kernel.org/r/20210831002531.116957-1-alexander@tsoy.me
+Signed-off-by: Takashi Iwai <tiwai@suse.de>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ sound/usb/quirks.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/sound/usb/quirks.c
++++ b/sound/usb/quirks.c
+@@ -1841,6 +1841,7 @@ static const struct registration_quirk r
+       REG_QUIRK_ENTRY(0x0951, 0x16ed, 2),     /* Kingston HyperX Cloud Alpha S */
+       REG_QUIRK_ENTRY(0x0951, 0x16ea, 2),     /* Kingston HyperX Cloud Flight S */
+       REG_QUIRK_ENTRY(0x0ecb, 0x1f46, 2),     /* JBL Quantum 600 */
++      REG_QUIRK_ENTRY(0x0ecb, 0x1f47, 2),     /* JBL Quantum 800 */
+       REG_QUIRK_ENTRY(0x0ecb, 0x2039, 2),     /* JBL Quantum 400 */
+       REG_QUIRK_ENTRY(0x0ecb, 0x203c, 2),     /* JBL Quantum 600 */
+       REG_QUIRK_ENTRY(0x0ecb, 0x203e, 2),     /* JBL Quantum 800 */
diff --git a/queue-5.4/pci-call-max-payload-size-related-fixup-quirks-early.patch b/queue-5.4/pci-call-max-payload-size-related-fixup-quirks-early.patch
new file mode 100644 (file)
index 0000000..e7dc6c8
--- /dev/null
@@ -0,0 +1,49 @@
+From b8da302e2955fe4d41eb9d48199242674d77dbe0 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Marek=20Beh=C3=BAn?= <kabel@kernel.org>
+Date: Thu, 24 Jun 2021 19:14:17 +0200
+Subject: PCI: Call Max Payload Size-related fixup quirks early
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Marek BehĂșn <kabel@kernel.org>
+
+commit b8da302e2955fe4d41eb9d48199242674d77dbe0 upstream.
+
+pci_device_add() calls HEADER fixups after pci_configure_device(), which
+configures Max Payload Size.
+
+Convert MPS-related fixups to EARLY fixups so pci_configure_mps() takes
+them into account.
+
+Fixes: 27d868b5e6cfa ("PCI: Set MPS to match upstream bridge")
+Link: https://lore.kernel.org/r/20210624171418.27194-1-kabel@kernel.org
+Signed-off-by: Marek BehĂșn <kabel@kernel.org>
+Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
+Cc: stable@vger.kernel.org
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/pci/quirks.c |   12 ++++++------
+ 1 file changed, 6 insertions(+), 6 deletions(-)
+
+--- a/drivers/pci/quirks.c
++++ b/drivers/pci/quirks.c
+@@ -3246,12 +3246,12 @@ static void fixup_mpss_256(struct pci_de
+ {
+       dev->pcie_mpss = 1; /* 256 bytes */
+ }
+-DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SOLARFLARE,
+-                       PCI_DEVICE_ID_SOLARFLARE_SFC4000A_0, fixup_mpss_256);
+-DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SOLARFLARE,
+-                       PCI_DEVICE_ID_SOLARFLARE_SFC4000A_1, fixup_mpss_256);
+-DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SOLARFLARE,
+-                       PCI_DEVICE_ID_SOLARFLARE_SFC4000B, fixup_mpss_256);
++DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLARFLARE,
++                      PCI_DEVICE_ID_SOLARFLARE_SFC4000A_0, fixup_mpss_256);
++DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLARFLARE,
++                      PCI_DEVICE_ID_SOLARFLARE_SFC4000A_1, fixup_mpss_256);
++DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLARFLARE,
++                      PCI_DEVICE_ID_SOLARFLARE_SFC4000B, fixup_mpss_256);
+ /*
+  * Intel 5000 and 5100 Memory controllers have an erratum with read completion
index d80de24db64f01c303b19f9302fac206ef959d44..3da204f7fc435cd06acf365e6eba2eb00d70b94b 100644 (file)
@@ -28,3 +28,10 @@ mm-page_alloc-speed-up-the-iteration-of-max_order.patch
 revert-r8169-avoid-link-up-interrupt-issue-on-rtl8106e-if-user-enables-aspm.patch
 x86-events-amd-iommu-fix-invalid-perf-result-due-to-iommu-pmc-power-gating.patch
 revert-btrfs-compression-don-t-try-to-compress-if-we-don-t-have-enough-pages.patch
+alsa-usb-audio-add-registration-quirk-for-jbl-quantum-800.patch
+usb-host-xhci-rcar-don-t-reload-firmware-after-the-completion.patch
+usb-mtu3-use-mult-for-hs-isoc-or-intr.patch
+usb-mtu3-fix-the-wrong-hs-mult-value.patch
+xhci-fix-unsafe-memory-usage-in-xhci-tracing.patch
+x86-reboot-limit-dell-optiplex-990-quirk-to-early-bios-versions.patch
+pci-call-max-payload-size-related-fixup-quirks-early.patch
diff --git a/queue-5.4/usb-host-xhci-rcar-don-t-reload-firmware-after-the-completion.patch b/queue-5.4/usb-host-xhci-rcar-don-t-reload-firmware-after-the-completion.patch
new file mode 100644 (file)
index 0000000..3068ce8
--- /dev/null
@@ -0,0 +1,38 @@
+From 57f3ffdc11143f56f1314972fe86fe17a0dcde85 Mon Sep 17 00:00:00 2001
+From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
+Date: Fri, 27 Aug 2021 15:32:27 +0900
+Subject: usb: host: xhci-rcar: Don't reload firmware after the completion
+
+From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
+
+commit 57f3ffdc11143f56f1314972fe86fe17a0dcde85 upstream.
+
+According to the datasheet, "Upon the completion of FW Download,
+there is no need to write or reload FW.". Otherwise, it's possible
+to cause unexpected behaviors. So, adds such a condition.
+
+Fixes: 4ac8918f3a73 ("usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers")
+Cc: stable@vger.kernel.org # v3.17+
+Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
+Link: https://lore.kernel.org/r/20210827063227.81990-1-yoshihiro.shimoda.uh@renesas.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/usb/host/xhci-rcar.c |    7 +++++++
+ 1 file changed, 7 insertions(+)
+
+--- a/drivers/usb/host/xhci-rcar.c
++++ b/drivers/usb/host/xhci-rcar.c
+@@ -134,6 +134,13 @@ static int xhci_rcar_download_firmware(s
+       const struct soc_device_attribute *attr;
+       const char *firmware_name;
++      /*
++       * According to the datasheet, "Upon the completion of FW Download,
++       * there is no need to write or reload FW".
++       */
++      if (readl(regs + RCAR_USB3_DL_CTRL) & RCAR_USB3_DL_CTRL_FW_SUCCESS)
++              return 0;
++
+       attr = soc_device_match(rcar_quirks_match);
+       if (attr)
+               quirks = (uintptr_t)attr->data;
diff --git a/queue-5.4/usb-mtu3-fix-the-wrong-hs-mult-value.patch b/queue-5.4/usb-mtu3-fix-the-wrong-hs-mult-value.patch
new file mode 100644 (file)
index 0000000..61d2297
--- /dev/null
@@ -0,0 +1,49 @@
+From 44e4439d8f9f8d0e9da767d1f31e7c211081feca Mon Sep 17 00:00:00 2001
+From: Chunfeng Yun <chunfeng.yun@mediatek.com>
+Date: Fri, 13 Aug 2021 14:30:49 +0800
+Subject: usb: mtu3: fix the wrong HS mult value
+
+From: Chunfeng Yun <chunfeng.yun@mediatek.com>
+
+commit 44e4439d8f9f8d0e9da767d1f31e7c211081feca upstream.
+
+usb_endpoint_maxp() returns actual max packet size, @mult will
+always be zero, fix it by using usb_endpoint_maxp_mult() instead
+to get mult.
+
+Fixes: 4d79e042ed8b ("usb: mtu3: add support for usb3.1 IP")
+Cc: stable@vger.kernel.org
+Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
+Link: https://lore.kernel.org/r/1628836253-7432-3-git-send-email-chunfeng.yun@mediatek.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/usb/mtu3/mtu3_gadget.c |    6 ++----
+ 1 file changed, 2 insertions(+), 4 deletions(-)
+
+--- a/drivers/usb/mtu3/mtu3_gadget.c
++++ b/drivers/usb/mtu3/mtu3_gadget.c
+@@ -72,14 +72,12 @@ static int mtu3_ep_enable(struct mtu3_ep
+       u32 interval = 0;
+       u32 mult = 0;
+       u32 burst = 0;
+-      int max_packet;
+       int ret;
+       desc = mep->desc;
+       comp_desc = mep->comp_desc;
+       mep->type = usb_endpoint_type(desc);
+-      max_packet = usb_endpoint_maxp(desc);
+-      mep->maxp = max_packet & GENMASK(10, 0);
++      mep->maxp = usb_endpoint_maxp(desc);
+       switch (mtu->g.speed) {
+       case USB_SPEED_SUPER:
+@@ -100,7 +98,7 @@ static int mtu3_ep_enable(struct mtu3_ep
+                               usb_endpoint_xfer_int(desc)) {
+                       interval = desc->bInterval;
+                       interval = clamp_val(interval, 1, 16) - 1;
+-                      mult = (max_packet & GENMASK(12, 11)) >> 11;
++                      mult = usb_endpoint_maxp_mult(desc) - 1;
+               }
+               break;
+       default:
diff --git a/queue-5.4/usb-mtu3-use-mult-for-hs-isoc-or-intr.patch b/queue-5.4/usb-mtu3-use-mult-for-hs-isoc-or-intr.patch
new file mode 100644 (file)
index 0000000..17c7f0b
--- /dev/null
@@ -0,0 +1,32 @@
+From fd7cb394ec7efccc3985feb0978cee4d352e1817 Mon Sep 17 00:00:00 2001
+From: Chunfeng Yun <chunfeng.yun@mediatek.com>
+Date: Fri, 13 Aug 2021 14:30:48 +0800
+Subject: usb: mtu3: use @mult for HS isoc or intr
+
+From: Chunfeng Yun <chunfeng.yun@mediatek.com>
+
+commit fd7cb394ec7efccc3985feb0978cee4d352e1817 upstream.
+
+For HS isoc or intr, should use @mult but not @burst
+to save mult value.
+
+Fixes: 4d79e042ed8b ("usb: mtu3: add support for usb3.1 IP")
+Cc: stable@vger.kernel.org
+Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
+Link: https://lore.kernel.org/r/1628836253-7432-2-git-send-email-chunfeng.yun@mediatek.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/usb/mtu3/mtu3_gadget.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/usb/mtu3/mtu3_gadget.c
++++ b/drivers/usb/mtu3/mtu3_gadget.c
+@@ -100,7 +100,7 @@ static int mtu3_ep_enable(struct mtu3_ep
+                               usb_endpoint_xfer_int(desc)) {
+                       interval = desc->bInterval;
+                       interval = clamp_val(interval, 1, 16) - 1;
+-                      burst = (max_packet & GENMASK(12, 11)) >> 11;
++                      mult = (max_packet & GENMASK(12, 11)) >> 11;
+               }
+               break;
+       default:
diff --git a/queue-5.4/x86-reboot-limit-dell-optiplex-990-quirk-to-early-bios-versions.patch b/queue-5.4/x86-reboot-limit-dell-optiplex-990-quirk-to-early-bios-versions.patch
new file mode 100644 (file)
index 0000000..bfce2f7
--- /dev/null
@@ -0,0 +1,87 @@
+From a729691b541f6e63043beae72e635635abe5dc09 Mon Sep 17 00:00:00 2001
+From: Paul Gortmaker <paul.gortmaker@windriver.com>
+Date: Sun, 30 May 2021 12:24:47 -0400
+Subject: x86/reboot: Limit Dell Optiplex 990 quirk to early BIOS versions
+
+From: Paul Gortmaker <paul.gortmaker@windriver.com>
+
+commit a729691b541f6e63043beae72e635635abe5dc09 upstream.
+
+When this platform was relatively new in November 2011, with early BIOS
+revisions, a reboot quirk was added in commit 6be30bb7d750 ("x86/reboot:
+Blacklist Dell OptiPlex 990 known to require PCI reboot")
+
+However, this quirk (and several others) are open-ended to all BIOS
+versions and left no automatic expiry if/when the system BIOS fixed the
+issue, meaning that nobody is likely to come along and re-test.
+
+What is really problematic with using PCI reboot as this quirk does, is
+that it causes this platform to do a full power down, wait one second,
+and then power back on.  This is less than ideal if one is using it for
+boot testing and/or bisecting kernels when legacy rotating hard disks
+are installed.
+
+It was only by chance that the quirk was noticed in dmesg - and when
+disabled it turned out that it wasn't required anymore (BIOS A24), and a
+default reboot would work fine without the "harshness" of power cycling the
+machine (and disks) down and up like the PCI reboot does.
+
+Doing a bit more research, it seems that the "newest" BIOS for which the
+issue was reported[1] was version A06, however Dell[2] seemed to suggest
+only up to and including version A05, with the A06 having a large number of
+fixes[3] listed.
+
+As is typical with a new platform, the initial BIOS updates come frequently
+and then taper off (and in this case, with a revival for CPU CVEs); a
+search for O990-A<ver>.exe reveals the following dates:
+
+        A02     16 Mar 2011
+        A03     11 May 2011
+        A06     14 Sep 2011
+        A07     24 Oct 2011
+        A10     08 Dec 2011
+        A14     06 Sep 2012
+        A16     15 Oct 2012
+        A18     30 Sep 2013
+        A19     23 Sep 2015
+        A20     02 Jun 2017
+        A23     07 Mar 2018
+        A24     21 Aug 2018
+
+While it's overkill to flash and test each of the above, it would seem
+likely that the issue was contained within A0x BIOS versions, given the
+dates above and the dates of issue reports[4] from distros.  So rather than
+just throw out the quirk entirely, limit the scope to just those early BIOS
+versions, in case people are still running systems from 2011 with the
+original as-shipped early A0x BIOS versions.
+
+[1] https://lore.kernel.org/lkml/1320373471-3942-1-git-send-email-trenn@suse.de/
+[2] https://www.dell.com/support/kbdoc/en-ca/000131908/linux-based-operating-systems-stall-upon-reboot-on-optiplex-390-790-990-systems
+[3] https://www.dell.com/support/home/en-ca/drivers/driversdetails?driverid=85j10
+[4] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/768039
+
+Fixes: 6be30bb7d750 ("x86/reboot: Blacklist Dell OptiPlex 990 known to require PCI reboot")
+Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
+Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
+Cc: stable@vger.kernel.org
+Link: https://lore.kernel.org/r/20210530162447.996461-4-paul.gortmaker@windriver.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ arch/x86/kernel/reboot.c |    3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+--- a/arch/x86/kernel/reboot.c
++++ b/arch/x86/kernel/reboot.c
+@@ -388,10 +388,11 @@ static const struct dmi_system_id reboot
+       },
+       {       /* Handle problems with rebooting on the OptiPlex 990. */
+               .callback = set_pci_reboot,
+-              .ident = "Dell OptiPlex 990",
++              .ident = "Dell OptiPlex 990 BIOS A0x",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 990"),
++                      DMI_MATCH(DMI_BIOS_VERSION, "A0"),
+               },
+       },
+       {       /* Handle problems with rebooting on Dell 300's */
diff --git a/queue-5.4/xhci-fix-unsafe-memory-usage-in-xhci-tracing.patch b/queue-5.4/xhci-fix-unsafe-memory-usage-in-xhci-tracing.patch
new file mode 100644 (file)
index 0000000..f80974d
--- /dev/null
@@ -0,0 +1,307 @@
+From cbf286e8ef8337308c259ff5b9ce2e74d403be5a Mon Sep 17 00:00:00 2001
+From: Mathias Nyman <mathias.nyman@linux.intel.com>
+Date: Fri, 20 Aug 2021 15:34:58 +0300
+Subject: xhci: fix unsafe memory usage in xhci tracing
+
+From: Mathias Nyman <mathias.nyman@linux.intel.com>
+
+commit cbf286e8ef8337308c259ff5b9ce2e74d403be5a upstream.
+
+Removes static char buffer usage in the following decode functions:
+       xhci_decode_trb()
+       xhci_decode_ptortsc()
+
+Caller must provide a buffer to use.
+In tracing use __get_str() as recommended to pass buffer.
+
+Minor chanes are needed in xhci debugfs code as these functions are also
+used there. Changes include moving XHCI_MSG_MAX definititon from
+xhci-trace.h to xhci.h
+
+Cc: <stable@vger.kernel.org>
+Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
+Link: https://lore.kernel.org/r/20210820123503.2605901-2-mathias.nyman@linux.intel.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/usb/host/xhci-debugfs.c |    6 +++-
+ drivers/usb/host/xhci-trace.h   |    8 +++---
+ drivers/usb/host/xhci.h         |   52 +++++++++++++++++++++-------------------
+ 3 files changed, 36 insertions(+), 30 deletions(-)
+
+--- a/drivers/usb/host/xhci-debugfs.c
++++ b/drivers/usb/host/xhci-debugfs.c
+@@ -197,12 +197,13 @@ static void xhci_ring_dump_segment(struc
+       int                     i;
+       dma_addr_t              dma;
+       union xhci_trb          *trb;
++      char                    str[XHCI_MSG_MAX];
+       for (i = 0; i < TRBS_PER_SEGMENT; i++) {
+               trb = &seg->trbs[i];
+               dma = seg->dma + i * sizeof(*trb);
+               seq_printf(s, "%pad: %s\n", &dma,
+-                         xhci_decode_trb(le32_to_cpu(trb->generic.field[0]),
++                         xhci_decode_trb(str, XHCI_MSG_MAX, le32_to_cpu(trb->generic.field[0]),
+                                          le32_to_cpu(trb->generic.field[1]),
+                                          le32_to_cpu(trb->generic.field[2]),
+                                          le32_to_cpu(trb->generic.field[3])));
+@@ -340,9 +341,10 @@ static int xhci_portsc_show(struct seq_f
+ {
+       struct xhci_port        *port = s->private;
+       u32                     portsc;
++      char                    str[XHCI_MSG_MAX];
+       portsc = readl(port->addr);
+-      seq_printf(s, "%s\n", xhci_decode_portsc(portsc));
++      seq_printf(s, "%s\n", xhci_decode_portsc(str, portsc));
+       return 0;
+ }
+--- a/drivers/usb/host/xhci-trace.h
++++ b/drivers/usb/host/xhci-trace.h
+@@ -25,8 +25,6 @@
+ #include "xhci.h"
+ #include "xhci-dbgcap.h"
+-#define XHCI_MSG_MAX  500
+-
+ DECLARE_EVENT_CLASS(xhci_log_msg,
+       TP_PROTO(struct va_format *vaf),
+       TP_ARGS(vaf),
+@@ -122,6 +120,7 @@ DECLARE_EVENT_CLASS(xhci_log_trb,
+               __field(u32, field1)
+               __field(u32, field2)
+               __field(u32, field3)
++              __dynamic_array(char, str, XHCI_MSG_MAX)
+       ),
+       TP_fast_assign(
+               __entry->type = ring->type;
+@@ -131,7 +130,7 @@ DECLARE_EVENT_CLASS(xhci_log_trb,
+               __entry->field3 = le32_to_cpu(trb->field[3]);
+       ),
+       TP_printk("%s: %s", xhci_ring_type_string(__entry->type),
+-                      xhci_decode_trb(__entry->field0, __entry->field1,
++                xhci_decode_trb(__get_str(str), XHCI_MSG_MAX, __entry->field0, __entry->field1,
+                                       __entry->field2, __entry->field3)
+       )
+ );
+@@ -523,6 +522,7 @@ DECLARE_EVENT_CLASS(xhci_log_portsc,
+                   TP_STRUCT__entry(
+                                    __field(u32, portnum)
+                                    __field(u32, portsc)
++                                   __dynamic_array(char, str, XHCI_MSG_MAX)
+                                    ),
+                   TP_fast_assign(
+                                  __entry->portnum = portnum;
+@@ -530,7 +530,7 @@ DECLARE_EVENT_CLASS(xhci_log_portsc,
+                                  ),
+                   TP_printk("port-%d: %s",
+                             __entry->portnum,
+-                            xhci_decode_portsc(__entry->portsc)
++                            xhci_decode_portsc(__get_str(str), __entry->portsc)
+                             )
+ );
+--- a/drivers/usb/host/xhci.h
++++ b/drivers/usb/host/xhci.h
+@@ -22,6 +22,9 @@
+ #include      "xhci-ext-caps.h"
+ #include "pci-quirks.h"
++/* max buffer size for trace and debug messages */
++#define XHCI_MSG_MAX          500
++
+ /* xHCI PCI Configuration Registers */
+ #define XHCI_SBRN_OFFSET      (0x60)
+@@ -2217,15 +2220,14 @@ static inline char *xhci_slot_state_stri
+       }
+ }
+-static inline const char *xhci_decode_trb(u32 field0, u32 field1, u32 field2,
+-              u32 field3)
++static inline const char *xhci_decode_trb(char *str, size_t size,
++                                        u32 field0, u32 field1, u32 field2, u32 field3)
+ {
+-      static char str[256];
+       int type = TRB_FIELD_TO_TYPE(field3);
+       switch (type) {
+       case TRB_LINK:
+-              sprintf(str,
++              snprintf(str, size,
+                       "LINK %08x%08x intr %d type '%s' flags %c:%c:%c:%c",
+                       field1, field0, GET_INTR_TARGET(field2),
+                       xhci_trb_type_string(type),
+@@ -2242,7 +2244,7 @@ static inline const char *xhci_decode_tr
+       case TRB_HC_EVENT:
+       case TRB_DEV_NOTE:
+       case TRB_MFINDEX_WRAP:
+-              sprintf(str,
++              snprintf(str, size,
+                       "TRB %08x%08x status '%s' len %d slot %d ep %d type '%s' flags %c:%c",
+                       field1, field0,
+                       xhci_trb_comp_code_string(GET_COMP_CODE(field2)),
+@@ -2255,7 +2257,8 @@ static inline const char *xhci_decode_tr
+               break;
+       case TRB_SETUP:
+-              sprintf(str, "bRequestType %02x bRequest %02x wValue %02x%02x wIndex %02x%02x wLength %d length %d TD size %d intr %d type '%s' flags %c:%c:%c",
++              snprintf(str, size,
++                      "bRequestType %02x bRequest %02x wValue %02x%02x wIndex %02x%02x wLength %d length %d TD size %d intr %d type '%s' flags %c:%c:%c",
+                               field0 & 0xff,
+                               (field0 & 0xff00) >> 8,
+                               (field0 & 0xff000000) >> 24,
+@@ -2272,7 +2275,8 @@ static inline const char *xhci_decode_tr
+                               field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_DATA:
+-              sprintf(str, "Buffer %08x%08x length %d TD size %d intr %d type '%s' flags %c:%c:%c:%c:%c:%c:%c",
++              snprintf(str, size,
++                       "Buffer %08x%08x length %d TD size %d intr %d type '%s' flags %c:%c:%c:%c:%c:%c:%c",
+                               field1, field0, TRB_LEN(field2), GET_TD_SIZE(field2),
+                               GET_INTR_TARGET(field2),
+                               xhci_trb_type_string(type),
+@@ -2285,7 +2289,8 @@ static inline const char *xhci_decode_tr
+                               field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_STATUS:
+-              sprintf(str, "Buffer %08x%08x length %d TD size %d intr %d type '%s' flags %c:%c:%c:%c",
++              snprintf(str, size,
++                       "Buffer %08x%08x length %d TD size %d intr %d type '%s' flags %c:%c:%c:%c",
+                               field1, field0, TRB_LEN(field2), GET_TD_SIZE(field2),
+                               GET_INTR_TARGET(field2),
+                               xhci_trb_type_string(type),
+@@ -2298,7 +2303,7 @@ static inline const char *xhci_decode_tr
+       case TRB_ISOC:
+       case TRB_EVENT_DATA:
+       case TRB_TR_NOOP:
+-              sprintf(str,
++              snprintf(str, size,
+                       "Buffer %08x%08x length %d TD size %d intr %d type '%s' flags %c:%c:%c:%c:%c:%c:%c:%c",
+                       field1, field0, TRB_LEN(field2), GET_TD_SIZE(field2),
+                       GET_INTR_TARGET(field2),
+@@ -2315,21 +2320,21 @@ static inline const char *xhci_decode_tr
+       case TRB_CMD_NOOP:
+       case TRB_ENABLE_SLOT:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: flags %c",
+                       xhci_trb_type_string(type),
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_DISABLE_SLOT:
+       case TRB_NEG_BANDWIDTH:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: slot %d flags %c",
+                       xhci_trb_type_string(type),
+                       TRB_TO_SLOT_ID(field3),
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_ADDR_DEV:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: ctx %08x%08x slot %d flags %c:%c",
+                       xhci_trb_type_string(type),
+                       field1, field0,
+@@ -2338,7 +2343,7 @@ static inline const char *xhci_decode_tr
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_CONFIG_EP:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: ctx %08x%08x slot %d flags %c:%c",
+                       xhci_trb_type_string(type),
+                       field1, field0,
+@@ -2347,7 +2352,7 @@ static inline const char *xhci_decode_tr
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_EVAL_CONTEXT:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: ctx %08x%08x slot %d flags %c",
+                       xhci_trb_type_string(type),
+                       field1, field0,
+@@ -2355,7 +2360,7 @@ static inline const char *xhci_decode_tr
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_RESET_EP:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: ctx %08x%08x slot %d ep %d flags %c:%c",
+                       xhci_trb_type_string(type),
+                       field1, field0,
+@@ -2376,7 +2381,7 @@ static inline const char *xhci_decode_tr
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_SET_DEQ:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: deq %08x%08x stream %d slot %d ep %d flags %c",
+                       xhci_trb_type_string(type),
+                       field1, field0,
+@@ -2387,14 +2392,14 @@ static inline const char *xhci_decode_tr
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_RESET_DEV:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: slot %d flags %c",
+                       xhci_trb_type_string(type),
+                       TRB_TO_SLOT_ID(field3),
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_FORCE_EVENT:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: event %08x%08x vf intr %d vf id %d flags %c",
+                       xhci_trb_type_string(type),
+                       field1, field0,
+@@ -2403,14 +2408,14 @@ static inline const char *xhci_decode_tr
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_SET_LT:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: belt %d flags %c",
+                       xhci_trb_type_string(type),
+                       TRB_TO_BELT(field3),
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_GET_BW:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: ctx %08x%08x slot %d speed %d flags %c",
+                       xhci_trb_type_string(type),
+                       field1, field0,
+@@ -2419,7 +2424,7 @@ static inline const char *xhci_decode_tr
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       case TRB_FORCE_HEADER:
+-              sprintf(str,
++              snprintf(str, size,
+                       "%s: info %08x%08x%08x pkt type %d roothub port %d flags %c",
+                       xhci_trb_type_string(type),
+                       field2, field1, field0 & 0xffffffe0,
+@@ -2428,7 +2433,7 @@ static inline const char *xhci_decode_tr
+                       field3 & TRB_CYCLE ? 'C' : 'c');
+               break;
+       default:
+-              sprintf(str,
++              snprintf(str, size,
+                       "type '%s' -> raw %08x %08x %08x %08x",
+                       xhci_trb_type_string(type),
+                       field0, field1, field2, field3);
+@@ -2553,9 +2558,8 @@ static inline const char *xhci_portsc_li
+       return "Unknown";
+ }
+-static inline const char *xhci_decode_portsc(u32 portsc)
++static inline const char *xhci_decode_portsc(char *str, u32 portsc)
+ {
+-      static char str[256];
+       int ret;
+       ret = sprintf(str, "%s %s %s Link:%s PortSpeed:%d ",