]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
perf ui browser annotate: Provide feedback on unhandled hotkeys
authorArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 8 Apr 2025 20:57:25 +0000 (17:57 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 10 Apr 2025 13:45:52 +0000 (10:45 -0300)
Don't just eat unknown keys without providing visual feedback and
instructions on how to see which ones are assigned.

Suggested-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/Z_TYux5fUg2pW-pF@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/annotate.c

index 135d6ce88fb3d4b61117b0dd614961df029a8f04..b452c02e07bf4819a15ea2d4139c9573b751c3dd 100644 (file)
@@ -928,6 +928,7 @@ show_sup_ins:
                case CTRL('c'):
                        goto out;
                default:
+                       ui_browser__warn_unhandled_hotkey(&browser->b, key, delay_secs, ", use 'h'/F1 to see actions");
                        continue;
                }