]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
hwrng: bcm2835 - Simplify with of_device_get_match_data()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 7 Nov 2025 08:15:49 +0000 (09:15 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 14 Nov 2025 10:15:48 +0000 (18:15 +0800)
Driver's probe function matches against driver's of_device_id table,
where each entry has non-NULL match data, so of_match_node() can be
simplified with of_device_get_match_data().

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/bcm2835-rng.c

index 0b67cfd15b11e0add95cfb91a57fd9d5239ef3ed..6d6ac409efcfaf6c1f608db2e43501f5801660c0 100644 (file)
@@ -142,9 +142,7 @@ MODULE_DEVICE_TABLE(of, bcm2835_rng_of_match);
 
 static int bcm2835_rng_probe(struct platform_device *pdev)
 {
-       const struct bcm2835_rng_of_data *of_data;
        struct device *dev = &pdev->dev;
-       const struct of_device_id *rng_id;
        struct bcm2835_rng_priv *priv;
        int err;
 
@@ -172,12 +170,10 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
        priv->rng.cleanup = bcm2835_rng_cleanup;
 
        if (dev_of_node(dev)) {
-               rng_id = of_match_node(bcm2835_rng_of_match, dev->of_node);
-               if (!rng_id)
-                       return -EINVAL;
+               const struct bcm2835_rng_of_data *of_data;
 
                /* Check for rng init function, execute it */
-               of_data = rng_id->data;
+               of_data = of_device_get_match_data(dev);
                if (of_data)
                        priv->mask_interrupts = of_data->mask_interrupts;
        }