Make GUC_check_errdetail messages full sentences

They were all missing punctuation, one was missing initial capital.
Per our message style guidelines.

No backpatch, to avoid breaking existing translations.

diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.c
index f249c3cd05e88d4f60b850f39ecc22c0e022fb46..0022c41c814b4ec57bec7541dbad259e2e2852b6 100644 (file)
--- a/src/backend/access/transam/slru.c
+++ b/src/backend/access/transam/slru.c
@@ -358,7 +358,7 @@ check_slru_buffers(const char *name, int *newval)
        if (*newval % SLRU_BANK_SIZE == 0)
                return true;
 
-       GUC_check_errdetail("\"%s\" must be a multiple of %d", name,
+       GUC_check_errdetail("\"%s\" must be a multiple of %d.", name,
                                                SLRU_BANK_SIZE);
        return false;
 }

diff --git a/src/backend/access/transam/xlogrecovery.c b/src/backend/access/transam/xlogrecovery.c
index 05c738d6614cabc7903e68794a6f7ab381244ff2..3943c357fa40f13c8fad92486b0eb2cfa504f471 100644 (file)
--- a/src/backend/access/transam/xlogrecovery.c
+++ b/src/backend/access/transam/xlogrecovery.c
@@ -4933,7 +4933,7 @@ check_recovery_target_time(char **newval, void **extra, GucSource source)
 
                        if (tm2timestamp(tm, fsec, &tz, &timestamp) != 0)
                        {
-                               GUC_check_errdetail("timestamp out of range: \"%s\"", str);
+                               GUC_check_errdetail("Timestamp out of range: \"%s\".", str);
                                return false;
                        }
                }

diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c
index 86f36b369543585779a6f30a6c8dc8d1f3976d88..1862cfb94d9298316fc169c2a1ce63289f9fd2c6 100644 (file)
--- a/src/backend/commands/vacuum.c
+++ b/src/backend/commands/vacuum.c
@@ -130,7 +130,8 @@ check_vacuum_buffer_usage_limit(int *newval, void **extra,
                return true;
 
        /* Value does not fall within any allowable range */
-       GUC_check_errdetail("\"vacuum_buffer_usage_limit\" must be 0 or between %d kB and %d kB",
+       GUC_check_errdetail("\"%s\" must be 0 or between %d kB and %d kB.",
+                                               "vacuum_buffer_usage_limit",
                                                MIN_BAS_VAC_RING_SIZE_KB, MAX_BAS_VAC_RING_SIZE_KB);
 
        return false;

diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c
index 6828100cf1ad720b0ee3a9a4474fa5cc108b3a24..9474d3dc74df117418e13434be859d52fb0f99c1 100644 (file)
--- a/src/backend/replication/slot.c
+++ b/src/backend/replication/slot.c
@@ -2478,7 +2478,7 @@ validate_sync_standby_slots(char *rawname, List **elemlist)
 
                        if (!slot)
                        {
-                               GUC_check_errdetail("replication slot \"%s\" does not exist",
+                               GUC_check_errdetail("Replication slot \"%s\" does not exist.",
                                                                        name);
                                ok = false;
                                break;
@@ -2486,7 +2486,7 @@ validate_sync_standby_slots(char *rawname, List **elemlist)
 
                        if (!SlotIsPhysical(slot))
                        {
-                               GUC_check_errdetail("\"%s\" is not a physical replication slot",
+                               GUC_check_errdetail("\"%s\" is not a physical replication slot.",
                                                                        name);
                                ok = false;
                                break;

diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.c
index fa5988c824ea087978a944213ea63ded47357864..c8931bac1376ebcfd16abbaa78acf105f700ff89 100644 (file)
--- a/src/backend/replication/syncrep.c
+++ b/src/backend/replication/syncrep.c
@@ -1010,7 +1010,8 @@ check_synchronous_standby_names(char **newval, void **extra, GucSource source)
                        if (syncrep_parse_error_msg)
                                GUC_check_errdetail("%s", syncrep_parse_error_msg);
                        else
-                               GUC_check_errdetail("\"synchronous_standby_names\" parser failed");
+                               GUC_check_errdetail("\"%s\" parser failed.",
+                                                                       "synchronous_standby_names");
                        return false;
                }
 

diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
index 42bf857e873f4052d137320d0a36e796f97014e3..7c403fb360e7c59acbe4248b9f979f0eeafc41a4 100644 (file)
--- a/src/backend/storage/file/fd.c
+++ b/src/backend/storage/file/fd.c
@@ -3985,7 +3985,7 @@ check_debug_io_direct(char **newval, void **extra, GucSource source)
 
        if (!SplitGUCList(rawstring, ',', &elemlist))
        {
-               GUC_check_errdetail("Invalid list syntax in parameter \"%s\"",
+               GUC_check_errdetail("Invalid list syntax in parameter \"%s\".",
                                                        "debug_io_direct");
                pfree(rawstring);
                list_free(elemlist);
@@ -4005,7 +4005,7 @@ check_debug_io_direct(char **newval, void **extra, GucSource source)
                        flags |= IO_DIRECT_WAL_INIT;
                else
                {
-                       GUC_check_errdetail("Invalid option \"%s\"", item);
+                       GUC_check_errdetail("Invalid option \"%s\".", item);
                        result = false;
                        break;
                }
@@ -4018,7 +4018,7 @@ check_debug_io_direct(char **newval, void **extra, GucSource source)
 #if XLOG_BLCKSZ < PG_IO_ALIGN_SIZE
        if (result && (flags & (IO_DIRECT_WAL | IO_DIRECT_WAL_INIT)))
        {
-               GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small",
+               GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small.",
                                                        "debug_io_direct", "XLOG_BLCKSZ");
                result = false;
        }
@@ -4026,7 +4026,7 @@ check_debug_io_direct(char **newval, void **extra, GucSource source)
 #if BLCKSZ < PG_IO_ALIGN_SIZE
        if (result && (flags & IO_DIRECT_DATA))
        {
-               GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small",
+               GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small.",
                                                        "debug_io_direct", "BLCKSZ");
                result = false;
        }

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 20b4b33228e1ba495aa7ca3f5031e7914d589cbb..b1a419d535c0ed41ed12ed3587bc86243754d5b9 100644 (file)
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2183,7 +2183,7 @@ check_backtrace_functions(char **newval, void **extra, GucSource source)
                                          ", \n\t");
        if (validlen != newvallen)
        {
-               GUC_check_errdetail("Invalid character");
+               GUC_check_errdetail("Invalid character.");
                return false;
        }