fetch: drop unneeded NULL-check for `remote_ref`

Drop the `NULL` check for `remote_ref` in `update_local_ref()`. The
function only has a single caller, and that caller always passes in a
non-`NULL` value.

This fixes a false positive in Coverity.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/fetch.c b/builtin/fetch.c
index 9147b700e556d3d41a487ae0b6317b6b139bf6a7..f268322e6ff742335a766fe5cff2079763eb6b51 100644 (file)
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -953,11 +953,10 @@ static int update_local_ref(struct ref *ref,
                 * Base this on the remote's ref name, as it's
                 * more likely to follow a standard layout.
                 */
-               const char *name = remote_ref ? remote_ref->name : "";
-               if (starts_with(name, "refs/tags/")) {
+               if (starts_with(remote_ref->name, "refs/tags/")) {
                        msg = "storing tag";
                        what = _("[new tag]");
-               } else if (starts_with(name, "refs/heads/")) {
+               } else if (starts_with(remote_ref->name, "refs/heads/")) {
                        msg = "storing head";
                        what = _("[new branch]");
                } else {