]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-storage: Harden check for imapdir list name
authorJosef 'Jeff' Sipek <jeff.sipek@dovecot.fi>
Fri, 11 May 2018 14:53:46 +0000 (10:53 -0400)
committerAki Tuomi <aki.tuomi@dovecot.fi>
Tue, 7 Aug 2018 10:33:18 +0000 (13:33 +0300)
Comparing char pointers to determine string equality is asking for trouble.
Use strcmp() instead.

src/lib-storage/list/mailbox-list-maildir.c

index 907772898012af0bbb8fbbb441a93c111e1514e9..437521a5e693e784f4cfa2d3e2cba3e3d86d46c5 100644 (file)
@@ -68,7 +68,7 @@ maildir_list_get_dirname_path(struct mailbox_list *list, const char *dir,
 {
        if (*name == '\0')
                return dir;
-       else if (list->name == imapdir_mailbox_list.name)
+       else if (strcmp(list->name, imapdir_mailbox_list.name) == 0)
                return t_strdup_printf("%s/%s", dir, name);
 
        return t_strdup_printf("%s/%c%s", dir,