fsmonitor: relocate socket file if .git directory is remote

If the .git directory is on a remote filesystem, create the socket
file in 'fsmonitor.socketDir' if it is defined, else create it in $HOME.

Signed-off-by: Eric DeCosta <edecosta@mathworks.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/Makefile b/Makefile
index 4235dd90cf2bb094651fcf67faf1966a11babf34..07aee14475fd2a68599da2eba03eba537f5e1051 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -2032,6 +2032,7 @@ ifdef FSMONITOR_DAEMON_BACKEND
        COMPAT_CFLAGS += -DHAVE_FSMONITOR_DAEMON_BACKEND
        COMPAT_OBJS += compat/fsmonitor/fsm-listen-$(FSMONITOR_DAEMON_BACKEND).o
        COMPAT_OBJS += compat/fsmonitor/fsm-health-$(FSMONITOR_DAEMON_BACKEND).o
+       COMPAT_OBJS += compat/fsmonitor/fsm-ipc-$(FSMONITOR_DAEMON_BACKEND).o
 endif
 
 ifdef FSMONITOR_OS_SETTINGS

diff --git a/builtin/fsmonitor--daemon.c b/builtin/fsmonitor--daemon.c
index 2c109cf8b377712a1bb2849ee83724d9c3473656..0123fc33ed278a3ac79b6fb1d5aa5f8fa49f1050 100644 (file)
--- a/builtin/fsmonitor--daemon.c
+++ b/builtin/fsmonitor--daemon.c
@@ -1343,7 +1343,8 @@ static int fsmonitor_run_daemon(void)
         * directory.)
         */
        strbuf_init(&state.path_ipc, 0);
-       strbuf_addstr(&state.path_ipc, absolute_path(fsmonitor_ipc__get_path()));
+       strbuf_addstr(&state.path_ipc,
+               absolute_path(fsmonitor_ipc__get_path(the_repository)));
 
        /*
         * Confirm that we can create platform-specific resources for the

diff --git a/compat/fsmonitor/fsm-ipc-darwin.c b/compat/fsmonitor/fsm-ipc-darwin.c
new file mode 100644 (file)
index 0000000..ce843d6
--- /dev/null
+++ b/compat/fsmonitor/fsm-ipc-darwin.c
@@ -0,0 +1,52 @@
+#include "cache.h"
+#include "config.h"
+#include "strbuf.h"
+#include "fsmonitor.h"
+#include "fsmonitor-ipc.h"
+#include "fsmonitor-path-utils.h"
+
+static GIT_PATH_FUNC(fsmonitor_ipc__get_default_path, "fsmonitor--daemon.ipc")
+
+const char *fsmonitor_ipc__get_path(struct repository *r)
+{
+       static const char *ipc_path = NULL;
+       SHA_CTX sha1ctx;
+       char *sock_dir = NULL;
+       struct strbuf ipc_file = STRBUF_INIT;
+       unsigned char hash[SHA_DIGEST_LENGTH];
+
+       if (!r)
+               BUG("No repository passed into fsmonitor_ipc__get_path");
+
+       if (ipc_path)
+               return ipc_path;
+
+
+       /* By default the socket file is created in the .git directory */
+       if (fsmonitor__is_fs_remote(r->gitdir) < 1) {
+               ipc_path = fsmonitor_ipc__get_default_path();
+               return ipc_path;
+       }
+
+       SHA1_Init(&sha1ctx);
+       SHA1_Update(&sha1ctx, r->worktree, strlen(r->worktree));
+       SHA1_Final(hash, &sha1ctx);
+
+       repo_config_get_string(r, "fsmonitor.socketdir", &sock_dir);
+
+       /* Create the socket file in either socketDir or $HOME */
+       if (sock_dir && *sock_dir) {
+               strbuf_addf(&ipc_file, "%s/.git-fsmonitor-%s",
+                                       sock_dir, hash_to_hex(hash));
+       } else {
+               strbuf_addf(&ipc_file, "~/.git-fsmonitor-%s", hash_to_hex(hash));
+       }
+       free(sock_dir);
+
+       ipc_path = interpolate_path(ipc_file.buf, 1);
+       if (!ipc_path)
+               die(_("Invalid path: %s"), ipc_file.buf);
+
+       strbuf_release(&ipc_file);
+       return ipc_path;
+}

diff --git a/compat/fsmonitor/fsm-ipc-win32.c b/compat/fsmonitor/fsm-ipc-win32.c
new file mode 100644 (file)
index 0000000..e08c505
--- /dev/null
+++ b/compat/fsmonitor/fsm-ipc-win32.c
@@ -0,0 +1,9 @@
+#include "config.h"
+#include "fsmonitor-ipc.h"
+
+const char *fsmonitor_ipc__get_path(struct repository *r) {
+       static char *ret;
+       if (!ret)
+               ret = git_pathdup("fsmonitor--daemon.ipc");
+       return ret;
+}

diff --git a/compat/fsmonitor/fsm-settings-darwin.c b/compat/fsmonitor/fsm-settings-darwin.c
index 699f0b272e68e28a1e8cbf24e3852cfbf4ba5a5f..7241c4c22c9af7c24ab7c2ec6d8ce5cf462e8c72 100644 (file)
--- a/compat/fsmonitor/fsm-settings-darwin.c
+++ b/compat/fsmonitor/fsm-settings-darwin.c
@@ -26,7 +26,7 @@
 static enum fsmonitor_reason check_uds_volume(struct repository *r)
 {
        struct fs_info fs;
-       const char *ipc_path = fsmonitor_ipc__get_path();
+       const char *ipc_path = fsmonitor_ipc__get_path(r);
        struct strbuf path = STRBUF_INIT;
        strbuf_add(&path, ipc_path, strlen(ipc_path));
 

diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt
index b88494bf59b5c3d5cd3c5ab06a1faa6ad51c1e85..7e7b6b9a3622270c3c389c9e1d70a6ad2462bf8f 100644 (file)
--- a/contrib/buildsystems/CMakeLists.txt
+++ b/contrib/buildsystems/CMakeLists.txt
@@ -308,6 +308,7 @@ if(SUPPORTS_SIMPLE_IPC)
                add_compile_definitions(HAVE_FSMONITOR_DAEMON_BACKEND)
                list(APPEND compat_SOURCES compat/fsmonitor/fsm-listen-win32.c)
                list(APPEND compat_SOURCES compat/fsmonitor/fsm-health-win32.c)
+               list(APPEND compat_SOURCES compat/fsmonitor/fsm-ipc-win32.c)
                list(APPEND compat_SOURCES compat/fsmonitor/fsm-path-utils-win32.c)
 
                add_compile_definitions(HAVE_FSMONITOR_OS_SETTINGS)
@@ -316,6 +317,7 @@ if(SUPPORTS_SIMPLE_IPC)
                add_compile_definitions(HAVE_FSMONITOR_DAEMON_BACKEND)
                list(APPEND compat_SOURCES compat/fsmonitor/fsm-listen-darwin.c)
                list(APPEND compat_SOURCES compat/fsmonitor/fsm-health-darwin.c)
+               list(APPEND compat_SOURCES compat/fsmonitor/fsm-ipc-darwin.c)
                list(APPEND compat_SOURCES compat/fsmonitor/fsm-path-utils-darwin.c)
 
                add_compile_definitions(HAVE_FSMONITOR_OS_SETTINGS)

diff --git a/fsmonitor-ipc.c b/fsmonitor-ipc.c
index 789e7397baa48d9172213b5319618d81ff6d60d1..c0f42301c849c7d697816a0e56577283dba32949 100644 (file)
--- a/fsmonitor-ipc.c
+++ b/fsmonitor-ipc.c
@@ -18,7 +18,7 @@ int fsmonitor_ipc__is_supported(void)
        return 0;
 }
 
-const char *fsmonitor_ipc__get_path(void)
+const char *fsmonitor_ipc__get_path(struct repository *r)
 {
        return NULL;
 }
@@ -47,11 +47,9 @@ int fsmonitor_ipc__is_supported(void)
        return 1;
 }
 
-GIT_PATH_FUNC(fsmonitor_ipc__get_path, "fsmonitor--daemon.ipc")
-
 enum ipc_active_state fsmonitor_ipc__get_state(void)
 {
-       return ipc_get_active_state(fsmonitor_ipc__get_path());
+       return ipc_get_active_state(fsmonitor_ipc__get_path(the_repository));
 }
 
 static int spawn_daemon(void)
@@ -81,8 +79,8 @@ int fsmonitor_ipc__send_query(const char *since_token,
        trace2_data_string("fsm_client", NULL, "query/command", tok);
 
 try_again:
-       state = ipc_client_try_connect(fsmonitor_ipc__get_path(), &options,
-                                      &connection);
+       state = ipc_client_try_connect(fsmonitor_ipc__get_path(the_repository),
+                                               &options, &connection);
 
        switch (state) {
        case IPC_STATE__LISTENING:
@@ -117,13 +115,13 @@ try_again:
 
        case IPC_STATE__INVALID_PATH:
                ret = error(_("fsmonitor_ipc__send_query: invalid path '%s'"),
-                           fsmonitor_ipc__get_path());
+                           fsmonitor_ipc__get_path(the_repository));
                goto done;
 
        case IPC_STATE__OTHER_ERROR:
        default:
                ret = error(_("fsmonitor_ipc__send_query: unspecified error on '%s'"),
-                           fsmonitor_ipc__get_path());
+                           fsmonitor_ipc__get_path(the_repository));
                goto done;
        }
 
@@ -149,8 +147,8 @@ int fsmonitor_ipc__send_command(const char *command,
        options.wait_if_busy = 1;
        options.wait_if_not_found = 0;
 
-       state = ipc_client_try_connect(fsmonitor_ipc__get_path(), &options,
-                                      &connection);
+       state = ipc_client_try_connect(fsmonitor_ipc__get_path(the_repository),
+                                               &options, &connection);
        if (state != IPC_STATE__LISTENING) {
                die(_("fsmonitor--daemon is not running"));
                return -1;

diff --git a/fsmonitor-ipc.h b/fsmonitor-ipc.h
index b6a7067c3af511bda2e3c2f4d4a8af436b8f5ad2..8b489da762b04756b2373332eb72634889d96b7f 100644 (file)
--- a/fsmonitor-ipc.h
+++ b/fsmonitor-ipc.h
@@ -3,6 +3,8 @@
 
 #include "simple-ipc.h"
 
+struct repository;
+
 /*
  * Returns true if built-in file system monitor daemon is defined
  * for this platform.
@@ -16,7 +18,7 @@ int fsmonitor_ipc__is_supported(void);
  *
  * Returns NULL if the daemon is not supported on this platform.
  */
-const char *fsmonitor_ipc__get_path(void);
+const char *fsmonitor_ipc__get_path(struct repository *r);
 
 /*
  * Try to determine whether there is a `git-fsmonitor--daemon` process