]> git.ipfire.org Git - thirdparty/collectd.git/commitdiff
Add checking status after returning from distribution_sub function
authorBarbara Kaczorowska <bkjg@google.com>
Mon, 17 Aug 2020 10:00:47 +0000 (10:00 +0000)
committerBarbara Kaczorowska <bkjg@google.com>
Wed, 19 Aug 2020 07:42:07 +0000 (07:42 +0000)
src/daemon/utils_cache.c

index 2e478572bdfd7bb786d2c27c994ff8b39154356c..10a4ec48997d23bb6042441747197d638c941bd1 100644 (file)
@@ -354,11 +354,16 @@ static int uc_update_metric(metric_t const *m) {
   }
 
   case METRIC_TYPE_DISTRIBUTION: {
-    distribution_t *diff =
+    int status =
         distribution_sub(ce->values_raw.distribution, m->value.distribution);
+
+    if (status != 0) {
+      ERROR("uc_update: distribution_sub failed with status %d.", status);
+      return status;
+    }
+
     distribution_destroy(ce->values_distribution);
-    distribution_destroy(ce->values_raw.distribution);
-    ce->values_distribution = diff;
+    ce->values_distribution = ce->values_raw.distribution;
     ce->values_raw.distribution = m->value.distribution;
     break;
   }