]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
can: c_can: Simplify handling syscon error path
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 12 Feb 2025 20:23:13 +0000 (21:23 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 19 Feb 2025 09:44:20 +0000 (10:44 +0100)
Use error handling block instead of open-coding it in one of probe
failure cases.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Link: https://patch.msgid.link/20250212-syscon-phandle-args-can-v2-2-ac9a1253396b@linaro.org
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/c_can/c_can_platform.c

index 8968b6288ac7adc54894f09efbd869c950cce4bf..96d1225c41d0a93627015c4582c1ef1565f53174 100644 (file)
@@ -324,10 +324,8 @@ static int c_can_plat_probe(struct platform_device *pdev)
                        raminit->syscon = syscon_regmap_lookup_by_phandle(np,
                                                                          "syscon-raminit");
                        if (IS_ERR(raminit->syscon)) {
-                               /* can fail with -EPROBE_DEFER */
                                ret = PTR_ERR(raminit->syscon);
-                               free_c_can_dev(dev);
-                               return ret;
+                               goto exit_free_device;
                        }
 
                        if (of_property_read_u32_index(np, "syscon-raminit", 1,