]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts
authorH.J. Lu <hjl.tools@gmail.com>
Tue, 23 Apr 2024 14:07:51 +0000 (07:07 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Tue, 23 Apr 2024 15:30:20 +0000 (08:30 -0700)
Use long with bfd_copy_private_symbol_data to fix

.../binutils/objcopy.c: In
function ‘copy_object’:
.../binutils/objcopy.c:3383:17: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘long int’ [-Werror=sign-compare]
 3383 |   for (i = 0; i < symcount; i++)
      |                 ^

on 32-bit hosts.

PR binutils/14493
* objcopy.c (copy_object): Use long with
bfd_copy_private_symbol_data.

binutils/objcopy.c

index 634ebae3fc321e79d95819f5c471b86e6af6263d..e8ca1374935e1a048bcf8746a919e221f405cef5 100644 (file)
@@ -3380,8 +3380,8 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch)
       symcount = filter_symbols (ibfd, obfd, osympp, isympp, symcount);
     }
 
-  for (i = 0; i < symcount; i++)
-    if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i]))
+  for (long s = 0; s < symcount; s++)
+    if (!bfd_copy_private_symbol_data (ibfd, osympp[s], obfd, osympp[s]))
       {
        status = 1;
        return false;