Replace hand-rolled modulo with arc4random_uniform.

Fixes potential modulo-by-zero UB flagged by Coverity CID 405068

diff --git a/regress/netcat.c b/regress/netcat.c
index 0acedfd82493b6aafb62f5a9abf8997b4697053d..c6211178063678110ab5e200d6fd38c04b35bf08 100644 (file)
--- a/regress/netcat.c
+++ b/regress/netcat.c
@@ -1134,7 +1134,7 @@ build_ports(char *p)
                        char *c;
 
                        for (x = 0; x <= (hi - lo); x++) {
-                               y = (arc4random() & 0xFFFF) % (hi - lo);
+                               y = arc4random_uniform(hi - lo);
                                c = portlist[x];
                                portlist[x] = portlist[y];
                                portlist[y] = c;