]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests: mlxsw: sharedbuffer: Remove duplicate test cases
authorDanielle Ratson <danieller@nvidia.com>
Thu, 5 Dec 2024 16:36:00 +0000 (17:36 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Dec 2024 01:37:37 +0000 (17:37 -0800)
On both port_tc_ip_test() and port_tc_arp_test(), the max occupancy is
checked on $h2 twice, when only the error message is different and does not
match the check itself.

Remove the two duplicated test cases from the test.

Fixes: a865ad999603 ("selftests: mlxsw: Add shared buffer traffic test")
Signed-off-by: Danielle Ratson <danieller@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Link: https://patch.msgid.link/d9eb26f6fc16a06a30b5c2c16ad80caf502bc561.1733414773.git.petrm@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/drivers/net/mlxsw/sharedbuffer.sh

index a7b3d6cf31851e7f8b14f4315ae6c23229396146..21bebc5726f6fcbfb7053e87b3816ce879024d0a 100755 (executable)
@@ -131,11 +131,6 @@ port_tc_ip_test()
 
        devlink sb occupancy snapshot $DEVLINK_DEV
 
-       RET=0
-       max_occ=$(sb_occ_itc_check $dl_port2 $SB_ITC $exp_max_occ)
-       check_err $? "Expected ingress TC($SB_ITC) max occupancy to be $exp_max_occ, but got $max_occ"
-       log_test "physical port's($h1) ingress TC - IP packet"
-
        RET=0
        max_occ=$(sb_occ_itc_check $dl_port2 $SB_ITC $exp_max_occ)
        check_err $? "Expected ingress TC($SB_ITC) max occupancy to be $exp_max_occ, but got $max_occ"
@@ -158,11 +153,6 @@ port_tc_arp_test()
 
        devlink sb occupancy snapshot $DEVLINK_DEV
 
-       RET=0
-       max_occ=$(sb_occ_itc_check $dl_port2 $SB_ITC $exp_max_occ)
-       check_err $? "Expected ingress TC($SB_ITC) max occupancy to be $exp_max_occ, but got $max_occ"
-       log_test "physical port's($h1) ingress TC - ARP packet"
-
        RET=0
        max_occ=$(sb_occ_itc_check $dl_port2 $SB_ITC $exp_max_occ)
        check_err $? "Expected ingress TC($SB_ITC) max occupancy to be $exp_max_occ, but got $max_occ"