]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/panthor: Don't update MMU_INT_MASK in panthor_mmu_irq_handler()
authorBoris Brezillon <boris.brezillon@collabora.com>
Fri, 4 Apr 2025 08:09:33 +0000 (10:09 +0200)
committerBoris Brezillon <boris.brezillon@collabora.com>
Thu, 10 Apr 2025 13:00:11 +0000 (15:00 +0200)
Interrupts are automatically unmasked in
panthor_mmu_irq_threaded_handler() when the handler returns. Unmasking
prematurely might generate spurious interrupts if the IRQ line is
shared.

Changes in v2:
- New patch

Changes in v3:
- Add R-bs

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Link: https://lore.kernel.org/r/20250404080933.2912674-6-boris.brezillon@collabora.com
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
drivers/gpu/drm/panthor/panthor_mmu.c

index 0ba76982d45b657238074ae6690fe41b3e0a8fb5..dc173c6edde0f3a0dec81764b474fbdce93d336d 100644 (file)
@@ -1721,7 +1721,6 @@ static void panthor_mmu_irq_handler(struct panthor_device *ptdev, u32 status)
                 * re-enabled.
                 */
                ptdev->mmu->irq.mask = new_int_mask;
-               gpu_write(ptdev, MMU_INT_MASK, new_int_mask);
 
                if (ptdev->mmu->as.slots[as].vm)
                        ptdev->mmu->as.slots[as].vm->unhandled_fault = true;