]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
python: Fix length of Common Name x509 attribute
authorAndreas Schneider <asn@samba.org>
Wed, 27 Nov 2024 09:15:45 +0000 (10:15 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Wed, 27 Nov 2024 15:33:35 +0000 (15:33 +0000)
File "bin/python/samba/tests/krb5/pkinit_tests.py", line 1496, in
create_certificate
  x509.NameAttribute(NameOID.COMMON_NAME,
  ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
                     f'{cert_name}/emailAddress={cert_name}'),
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.13/site-packages/cryptography/x509/name.py",
line 152, in __init__
  raise ValueError(msg)
ValueError: Attribute's length must be >= 1 and <= 64, but it was 84

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
python/samba/tests/krb5/pkinit_tests.py

index dbd158b2dc2e4306cc65ec2507c72271925505f1..5278d4945cf090420ab689b1e4224696bf47c270 100755 (executable)
@@ -1493,8 +1493,7 @@ class PkInitTests(KDCBaseTest):
             x509.NameAttribute(NameOID.STATE_OR_PROVINCE_NAME, 'SambaState'),
             x509.NameAttribute(NameOID.ORGANIZATION_NAME, 'SambaSelfTesting'),
             x509.NameAttribute(NameOID.ORGANIZATIONAL_UNIT_NAME, 'Users'),
-            x509.NameAttribute(NameOID.COMMON_NAME,
-                               f'{cert_name}/emailAddress={cert_name}'),
+            x509.NameAttribute(NameOID.COMMON_NAME, f'{cert_name}'),
         ]))
 
         # The new certificate must be issued by the root CA.