modpost: require a MODULE_DESCRIPTION()

Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() has
resulted in a warning with make W=1. Since that time, all known
instances of this issue have been fixed. Therefore, now make it an
error if a MODULE_DESCRIPTION() is not present.

Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 7f4c72eca72c1b99bc8961ad4180fba8813c5c1e..92627e8d0e16605cf9277644d14f11c1f729f467 100644 (file)
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1602,8 +1602,8 @@ static void read_symbols(const char *modname)
                                                     namespace);
                }
 
-               if (extra_warn && !get_modinfo(&info, "description"))
-                       warn("missing MODULE_DESCRIPTION() in %s\n", modname);
+               if (!get_modinfo(&info, "description"))
+                       error("missing MODULE_DESCRIPTION() in %s\n", modname);
        }
 
        for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {