]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Docs: document ConnOpener::swanSong() better
authorAmos Jeffries <squid3@treenet.co.nz>
Thu, 28 Feb 2013 23:22:23 +0000 (16:22 -0700)
committerAmos Jeffries <squid3@treenet.co.nz>
Thu, 28 Feb 2013 23:22:23 +0000 (16:22 -0700)
src/comm/ConnOpener.cc

index a253faf6a7408c1dfe922774b10ec01c41ae5b0d..634b9f1d7455eb2620657c55dd486e057c2afd5f 100644 (file)
@@ -67,9 +67,11 @@ Comm::ConnOpener::swanSong()
         sendAnswer(COMM_ERR_CONNECT, 0, "Comm::ConnOpener::swanSong");
     }
 
+    // did we abort with a temporary FD assigned?
     if (temporaryFd_ >= 0)
         closeFd();
 
+    // did we abort while waiting between retries?
     if (calls_.sleep_)
         cancelSleep();
 
@@ -120,6 +122,7 @@ Comm::ConnOpener::sendAnswer(comm_err_t errFlag, int xerrno, const char *why)
         if (callback_->canceled()) {
             debugs(5, 4, conn_ << " not calling canceled " << *callback_ <<
                    " [" << callback_->id << ']' );
+            // TODO save the pconn to the pconnPool ?
         } else {
             typedef CommConnectCbParams Params;
             Params &params = GetCommParams<Params>(callback_);