]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
tun: add a missing rcu_read_unlock() in error path
authorEric Dumazet <edumazet@google.com>
Sat, 16 Mar 2019 20:09:53 +0000 (13:09 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Apr 2019 04:25:11 +0000 (06:25 +0200)
commit 9180bb4f046064dfa4541488102703b402bb04e1 upstream.

In my latest patch I missed one rcu_read_unlock(), in case
device is down.

Fixes: 4477138fa0ae ("tun: properly test for IFF_UP")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/tun.c

index 9d6431d13c98ffbea0470667852a97b57d60274a..3b13d9e4030a5884ea27b8e26abe956c07cc3126 100644 (file)
@@ -1569,6 +1569,7 @@ drop:
        rcu_read_lock();
        if (unlikely(!(tun->dev->flags & IFF_UP))) {
                err = -EIO;
+               rcu_read_unlock();
                goto drop;
        }