]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ice: improve error message for insufficient filter space
authorMartyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
Fri, 14 Mar 2025 08:11:11 +0000 (09:11 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 11 Apr 2025 18:58:57 +0000 (11:58 -0700)
When adding a rule to switch through tc, if the operation fails
due to not enough free recipes (-ENOSPC), provide a clearer
error message: "Unable to add filter: insufficient space available."

This improves user feedback by distinguishing space limitations from
other generic failures.

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_tc_lib.c

index 49b87071b7dc1a27009e03a94dcf5ecb3615c573..fb9ea7f8ef444ee8bec6c763d7980417ba0fc58f 100644 (file)
@@ -996,6 +996,9 @@ ice_eswitch_add_tc_fltr(struct ice_vsi *vsi, struct ice_tc_flower_fltr *fltr)
                NL_SET_ERR_MSG_MOD(fltr->extack, "Unable to add filter because it already exist");
                ret = -EINVAL;
                goto exit;
+       } else if (ret == -ENOSPC) {
+               NL_SET_ERR_MSG_MOD(fltr->extack, "Unable to add filter: insufficient space available.");
+               goto exit;
        } else if (ret) {
                NL_SET_ERR_MSG_MOD(fltr->extack, "Unable to add filter due to error");
                goto exit;
@@ -1228,6 +1231,10 @@ ice_add_tc_flower_adv_fltr(struct ice_vsi *vsi,
                                   "Unable to add filter because it already exist");
                ret = -EINVAL;
                goto exit;
+       } else if (ret == -ENOSPC) {
+               NL_SET_ERR_MSG_MOD(tc_fltr->extack,
+                                  "Unable to add filter: insufficient space available.");
+               goto exit;
        } else if (ret) {
                NL_SET_ERR_MSG_MOD(tc_fltr->extack,
                                   "Unable to add filter due to error");