]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
connect: mark intentional ignores of setsockopt return values
authorDaniel Stenberg <daniel@haxx.se>
Sun, 10 Jan 2021 23:13:01 +0000 (00:13 +0100)
committerDaniel Stenberg <daniel@haxx.se>
Mon, 11 Jan 2021 09:21:51 +0000 (10:21 +0100)
Pointed out by Coverity

Closes #6431

lib/connect.c

index f7aa26019906d12d95760617b46337598ee00e62..345b800ee8ac884bb1edaa2fdab289608f4090f4 100644 (file)
@@ -5,7 +5,7 @@
  *                            | (__| |_| |  _ <| |___
  *                             \___|\___/|_| \_\_____|
  *
- * Copyright (C) 1998 - 2020, Daniel Stenberg, <daniel@haxx.se>, et al.
+ * Copyright (C) 1998 - 2021, Daniel Stenberg, <daniel@haxx.se>, et al.
  *
  * This software is licensed as described in the file COPYING, which
  * you should have received as part of this distribution. The terms
@@ -445,7 +445,7 @@ static CURLcode bindlocal(struct connectdata *conn,
     }
   }
 #ifdef IP_BIND_ADDRESS_NO_PORT
-  setsockopt(sockfd, SOL_IP, IP_BIND_ADDRESS_NO_PORT, &on, sizeof(on));
+  (void)setsockopt(sockfd, SOL_IP, IP_BIND_ADDRESS_NO_PORT, &on, sizeof(on));
 #endif
   for(;;) {
     if(bind(sockfd, sock, sizeof_sa) >= 0) {
@@ -1578,18 +1578,17 @@ CURLcode Curl_socket(struct connectdata *conn,
   if(addr->socktype == SOCK_DGRAM) {
     int one = 1;
     switch(addr->family) {
-      case AF_INET:
-        setsockopt(*sockfd, SOL_IP, IP_RECVERR, &one, sizeof(one));
-        break;
-      case AF_INET6:
-        setsockopt(*sockfd, SOL_IPV6, IPV6_RECVERR, &one, sizeof(one));
-        break;
+    case AF_INET:
+      (void)setsockopt(*sockfd, SOL_IP, IP_RECVERR, &one, sizeof(one));
+      break;
+    case AF_INET6:
+      (void)setsockopt(*sockfd, SOL_IPV6, IPV6_RECVERR, &one, sizeof(one));
+      break;
     }
   }
 #endif
 
   return CURLE_OK;
-
 }
 
 /*