]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: dac: adi-axi-dac: modify stream enable
authorAngelo Dureghello <adureghello@baylibre.com>
Tue, 14 Jan 2025 15:30:12 +0000 (16:30 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 3 Feb 2025 19:15:38 +0000 (19:15 +0000)
Change suggested from the AXI HDL team, modify the function
axi_dac_data_stream_enable() to check for interface busy, to avoid
possible issues when starting the stream.

Fixes: e61d7178429a ("iio: dac: adi-axi-dac: extend features")
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
Link: https://patch.msgid.link/20250114-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v4-3-979402e33545@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/adi-axi-dac.c

index b143f7ed6847277aeb49094627d90e5d95eed71c..ac871deb8063cddb968468d880c64310148ff0a7 100644 (file)
@@ -585,6 +585,14 @@ static int axi_dac_ddr_disable(struct iio_backend *back)
 static int axi_dac_data_stream_enable(struct iio_backend *back)
 {
        struct axi_dac_state *st = iio_backend_get_priv(back);
+       int ret, val;
+
+       ret = regmap_read_poll_timeout(st->regmap,
+                               AXI_DAC_UI_STATUS_REG, val,
+                               FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, val) == 0,
+                               10, 100 * KILO);
+       if (ret)
+               return ret;
 
        return regmap_set_bits(st->regmap, AXI_DAC_CUSTOM_CTRL_REG,
                               AXI_DAC_CUSTOM_CTRL_STREAM_ENABLE);