arm: Add IT insns for thumb mode

These are ignored by the assembler in ARM mode, so by
default this has no effect on generated code.

diff --git a/ports/ChangeLog.arm b/ports/ChangeLog.arm
index fe0fd4680325ec75f5a06b527bda61a604e665c3..33a1f57f71db4bdca0738b42c00f4b8129666ca7 100644 (file)
--- a/ports/ChangeLog.arm
+++ b/ports/ChangeLog.arm
@@ -26,6 +26,17 @@
        * sysdeps/unix/sysv/linux/arm/nptl/unwind-resume.c
        (_Unwind_Resume): Likewise.
 
+       * ports/sysdeps/arm/arm-mcount.S: Always use unified syntax and
+       always add IT markup.
+       * sysdeps/unix/sysv/linux/arm/mmap64.S (__mmap64): Likewise.
+       * sysdeps/arm/dl-tlsdesc.S (_dl_tlsdesc_dynamic): Add IT markup.
+       * sysdeps/unix/arm/sysdep.S (__syscall_error): Likewise.
+       * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Likewise.
+       * sysdeps/unix/sysv/linux/arm/mmap.S (__mmap): Likewise.
+       * sysdeps/unix/sysv/linux/arm/syscall.S (syscall): Likewise.
+       * sysdeps/unix/sysv/linux/arm/sysdep.h (PSEUDO_RET): Likewise.
+       * sysdeps/unix/sysv/linux/arm/vfork.S (__vfork): Likewise.
+
 2013-02-27  Roland McGrath  <roland@hack.frob.com>
 
        * sysdeps/arm/sysdep.h (CFI_SECTIONS): New macro.

diff --git a/ports/sysdeps/arm/arm-mcount.S b/ports/sysdeps/arm/arm-mcount.S
index 6c24271396e7b385e4ee2ef0a86a9e3b7d5736a9..679d042ba4b9836adc876d4878d062645098bc3d 100644 (file)
--- a/ports/sysdeps/arm/arm-mcount.S
+++ b/ports/sysdeps/arm/arm-mcount.S
@@ -24,8 +24,8 @@
 
 #ifdef __thumb2__
        .thumb
-       .syntax unified
 #endif
+       .syntax unified
 
 
 /* Use an assembly stub with a special ABI.  The calling lr has been
@@ -77,15 +77,10 @@ ENTRY(_mcount)
        cfi_rel_offset (r3, 12)
        cfi_rel_offset (fp, 16)
        cfi_rel_offset (lr, 20)
-#ifdef __thumb2__
        movs r0, fp
        ittt ne
        ldrne r0, [r0, #-4]
-#else
-       movs fp, fp
-       ldrne r0, [fp, #-4]
-#endif
-       movnes r1, lr
+       movsne r1, lr
        blne __mcount_internal
 #ifdef __thumb2__
        ldmia sp!, {r0, r1, r2, r3, fp, pc}

diff --git a/ports/sysdeps/arm/dl-tlsdesc.S b/ports/sysdeps/arm/dl-tlsdesc.S
index 66759923b0895c4fa8c85bbaeeac2a193bfb0897..7b4c8dfcb5be7463cdb79390cb3b31560e7beeb4 100644 (file)
--- a/ports/sysdeps/arm/dl-tlsdesc.S
+++ b/ports/sysdeps/arm/dl-tlsdesc.S
@@ -116,6 +116,7 @@ _dl_tlsdesc_dynamic:
        ldr     r3, [r1]
        ldr     r2, [r0, r3, lsl #3]
        cmn     r2, #1
+       ittt    ne
        ldrne   r3, [r1, #4]
        addne   r3, r2, r3
        rsbne   r0, r4, r3

diff --git a/ports/sysdeps/unix/arm/sysdep.S b/ports/sysdeps/unix/arm/sysdep.S
index 99bca9fab1380ecbf77de4fe6e76c569d3e4e100..40e4d80ecaf675fb3e885d890c5bc1538ffdc4ca 100644 (file)
--- a/ports/sysdeps/unix/arm/sysdep.S
+++ b/ports/sysdeps/unix/arm/sysdep.S
@@ -31,8 +31,9 @@ __syscall_error:
        /* We translate the system's EWOULDBLOCK error into EAGAIN.
           The GNU C library always defines EWOULDBLOCK==EAGAIN.
           EWOULDBLOCK_sys is the original number.  */
-       cmp r0, $EWOULDBLOCK_sys /* Is it the old EWOULDBLOCK?  */
-       moveq r0, $EAGAIN       /* Yes; translate it to EAGAIN.  */
+       cmp     r0, $EWOULDBLOCK_sys /* Is it the old EWOULDBLOCK?  */
+       it      eq
+       moveq   r0, $EAGAIN     /* Yes; translate it to EAGAIN.  */
 #endif
 
 #ifndef IS_IN_rtld

diff --git a/ports/sysdeps/unix/sysv/linux/arm/clone.S b/ports/sysdeps/unix/sysv/linux/arm/clone.S
index de25db16092a3a43bfeb10de44de51205461cfb3..732a3ffd0176230803d4c2b238481f5774e07168 100644 (file)
--- a/ports/sysdeps/unix/sysv/linux/arm/clone.S
+++ b/ports/sysdeps/unix/sysv/linux/arm/clone.S
@@ -33,6 +33,7 @@
 ENTRY(__clone)
        @ sanity check args
        cmp     r0, #0
+       ite     ne
        cmpne   r1, #0
        moveq   r0, #-EINVAL
        beq     PLTJMP(syscall_error)
@@ -78,8 +79,9 @@ PSEUDO_END (__clone)
        sub     pc, r0, #31
        mov     r1, r0
        tst     ip, #CLONE_VM
-       movne   r0, #-1
        ldr     r7, =SYS_ify(getpid)
+       ite     ne
+       movne   r0, #-1
        swieq   0x0
        str     r0, [r1, #PID_OFFSET]
        str     r0, [r1, #TID_OFFSET]

diff --git a/ports/sysdeps/unix/sysv/linux/arm/mmap.S b/ports/sysdeps/unix/sysv/linux/arm/mmap.S
index fa8a2b86c88cf202a077f143ae602f54bb18c32e..68560b065edc1bea4bc0c6e8cfe85a1d660f9a34 100644 (file)
--- a/ports/sysdeps/unix/sysv/linux/arm/mmap.S
+++ b/ports/sysdeps/unix/sysv/linux/arm/mmap.S
@@ -51,6 +51,7 @@ ENTRY (__mmap)
        cfi_restore (r5)
 
        cmn     r0, $4096
+       it      cc
        RETINSTR(cc, lr)
        b       PLTJMP(syscall_error)
 

diff --git a/ports/sysdeps/unix/sysv/linux/arm/mmap64.S b/ports/sysdeps/unix/sysv/linux/arm/mmap64.S
index 2eafd1b41341b2fe09247d32a71ec94ee41e7530..dcbab3aed69c4bb4d7c58e5b31c55fd7e7827fcc 100644 (file)
--- a/ports/sysdeps/unix/sysv/linux/arm/mmap64.S
+++ b/ports/sysdeps/unix/sysv/linux/arm/mmap64.S
@@ -17,6 +17,8 @@
 
 #include <sysdep.h>
 
+       .syntax unified
+
 #define        EINVAL          22
 
 #ifdef __ARMEB__
@@ -42,7 +44,8 @@ ENTRY (__mmap64)
        cfi_remember_state
        movs    r4, ip, lsl $20         @ check that offset is page-aligned
        mov     ip, ip, lsr $12
-       moveqs  r4, r5, lsr $12         @ check for overflow
+       it      eq
+       movseq  r4, r5, lsr $12         @ check for overflow
        bne     .Linval
        ldr     r4, [sp, $8]            @ load fd
        orr     r5, ip, r5, lsl $20     @ compose page offset
@@ -52,6 +55,7 @@ ENTRY (__mmap64)
        cfi_adjust_cfa_offset (-8)
        cfi_restore (r4)
        cfi_restore (r5)
+       it      cc
        RETINSTR(cc, lr)
        b       PLTJMP(syscall_error)
 

diff --git a/ports/sysdeps/unix/sysv/linux/arm/syscall.S b/ports/sysdeps/unix/sysv/linux/arm/syscall.S
index c6dd57d6981254000360a9ce45c36ec9ad6d03a2..665ecb4de0f6874fbea2876a5083f09dfc71cfd1 100644 (file)
--- a/ports/sysdeps/unix/sysv/linux/arm/syscall.S
+++ b/ports/sysdeps/unix/sysv/linux/arm/syscall.S
@@ -42,6 +42,7 @@ ENTRY (syscall)
        cfi_restore (r6)
        cfi_restore (r7)
        cmn     r0, #4096
+       it      cc
        RETINSTR(cc, lr)
        b       PLTJMP(syscall_error)
 PSEUDO_END (syscall)

diff --git a/ports/sysdeps/unix/sysv/linux/arm/sysdep.h b/ports/sysdeps/unix/sysv/linux/arm/sysdep.h
index f9b3443c146a421c7b39701e48ece9667acf9fb7..f40cb95e87448bfb9b7faccafdc944d28995f230 100644 (file)
--- a/ports/sysdeps/unix/sysv/linux/arm/sysdep.h
+++ b/ports/sysdeps/unix/sysv/linux/arm/sysdep.h
@@ -64,6 +64,7 @@
        cmn     r0, $4096;
 
 #define PSEUDO_RET                                     \
+       it      cc;                                     \
        RETINSTR(cc, lr);                               \
        b       PLTJMP(SYSCALL_ERROR)
 #undef ret

diff --git a/ports/sysdeps/unix/sysv/linux/arm/vfork.S b/ports/sysdeps/unix/sysv/linux/arm/vfork.S
index 4f84c57f2289c3cc09109e51354c5399a97e1a2b..ae931f79c64fe06cc303d0e8f2c8d8d8a0c77b06 100644 (file)
--- a/ports/sysdeps/unix/sysv/linux/arm/vfork.S
+++ b/ports/sysdeps/unix/sysv/linux/arm/vfork.S
@@ -51,6 +51,7 @@ ENTRY (__vfork)
        RESTORE_PID
 #endif
        cmn     a1, #4096
+       it      cc
        RETINSTR(cc, lr)
 
        b       PLTJMP(SYSCALL_ERROR)