]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: rtw89: coex: initialize local .dbcc_2g_phy in _set_btg_ctrl()
authorPing-Ke Shih <pkshih@realtek.com>
Thu, 19 Sep 2024 08:12:15 +0000 (16:12 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Thu, 26 Sep 2024 01:22:02 +0000 (09:22 +0800)
For the case of DBCC enabled and fwrole version 0, the local variable
wl_rinfo.dbcc_2g_phy might not be set by following for-loop, leading
uninitialized variable before using.

Addresses-Coverity-ID: 1586724 ("Uninitialized scalar variable")

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20240919081216.28505-3-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/coex.c

index 3b3fd451e445b3c52f99bb5fa2323a9c481847d4..6da1193422fb1ab3f148d63e8b3308d0ada7b857 100644 (file)
@@ -4855,6 +4855,8 @@ static void _set_btg_ctrl(struct rtw89_dev *rtwdev)
 
        if (rtwdev->dbcc_en) {
                if (ver->fwlrole == 0) {
+                       wl_rinfo.dbcc_2g_phy = RTW89_PHY_MAX;
+
                        for (i = 0; i < RTW89_PHY_MAX; i++) {
                                if (wl_dinfo->real_band[i] == RTW89_BAND_2G)
                                        wl_rinfo.dbcc_2g_phy = i;