]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Check return code from setsockopt (CID 1231350)
authorFrancesco Chemolli <kinkie@squid-cache.org>
Mon, 20 Jul 2015 10:19:04 +0000 (12:19 +0200)
committerFrancesco Chemolli <kinkie@squid-cache.org>
Mon, 20 Jul 2015 10:19:04 +0000 (12:19 +0200)
src/clients/FtpGateway.cc

index 8b6dbfbdcbdc8d80a2bca7f0058261c7c8daae2e..3e44ba1586f1eb9e5246748dab0ff063e351be81 100644 (file)
@@ -1802,7 +1802,12 @@ ftpOpenListenSocket(Ftp::Gateway * ftpState, int fallback)
      */
     if (fallback) {
         int on = 1;
-        setsockopt(ftpState->ctrl.conn->fd, SOL_SOCKET, SO_REUSEADDR, (char *) &on, sizeof(on));
+        errno = 0;
+        if (setsockopt(ftpState->ctrl.conn->fd, SOL_SOCKET, SO_REUSEADDR,
+                        (char *) &on, sizeof(on)) == -1) {
+            // SO_REUSEADDR is only an optimization, no need to be verbose about error
+            debugs(9, 4, "setsockopt failed: " << xstrerror());
+        }
         ftpState->ctrl.conn->flags |= COMM_REUSEADDR;
         temp->flags |= COMM_REUSEADDR;
     } else {