]> git.ipfire.org Git - thirdparty/git.git/commitdiff
test-lib: use $1, not $@ in test_known_broken_{ok,failure}_
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Wed, 27 Jul 2022 23:13:29 +0000 (01:13 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 27 Jul 2022 23:35:39 +0000 (16:35 -0700)
Clarify that these two functions never take N arguments, they'll only
ever receive one. They've needlessly used $@ over $1 since
41ac414ea2b (Sane use of test_expect_failure, 2008-02-01).

In the future we might want to pass the test source to these, but now
that's not the case. This preparatory change helps to clarify a
follow-up change.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/test-lib.sh

index 7726d1da88a52f60408bc3d8223923533f23e627..3f11ce35112e2e03cdb1e2abe12ef77bce5f2753 100644 (file)
@@ -804,14 +804,14 @@ test_failure_ () {
 
 test_known_broken_ok_ () {
        test_fixed=$(($test_fixed+1))
-       say_color error "ok $test_count - $@ # TODO known breakage vanished"
-       finalize_test_case_output fixed "$@"
+       say_color error "ok $test_count - $1 # TODO known breakage vanished"
+       finalize_test_case_output fixed "$1"
 }
 
 test_known_broken_failure_ () {
        test_broken=$(($test_broken+1))
-       say_color warn "not ok $test_count - $@ # TODO known breakage"
-       finalize_test_case_output broken "$@"
+       say_color warn "not ok $test_count - $1 # TODO known breakage"
+       finalize_test_case_output broken "$1"
 }
 
 test_debug () {