]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
YaHTTP: Fix a non-virtual destructor warning in the `HTTPBase` class 14584/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 26 Aug 2024 08:47:10 +0000 (10:47 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 26 Aug 2024 08:47:10 +0000 (10:47 +0200)
`g++` 14.2.1's `-Wnon-virtual-dtor` complains:
```
‘class YaHTTP::HTTPBase’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
```

ext/yahttp/yahttp/reqresp.hpp

index 4db53bec85a1478f5ebdee563f415506388885fa..e420c24a153ba20487db5b6bf674d6a6438a85fd 100644 (file)
@@ -98,6 +98,7 @@ namespace YaHTTP {
     HTTPBase() {
       HTTPBase::initialize();
     };
+    virtual ~HTTPBase() = default;
 
     virtual void initialize() {
       kind = 0;