]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86: alienware-wmi: printing the wrong error code
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 24 Apr 2019 09:44:18 +0000 (12:44 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 8 May 2019 21:33:02 +0000 (00:33 +0300)
The "out_data" variable is uninitialized at the point.  Originally, this
used to print "status" instead and that seems like the correct thing to
print.

Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/alienware-wmi.c

index c0d1555735cddcc7526ed211d70e14189b5bc950..83fd7677af24c1f7f82aa0295eca0afcc0101d0b 100644 (file)
@@ -587,7 +587,7 @@ static ssize_t show_hdmi_source(struct device *dev,
                        return scnprintf(buf, PAGE_SIZE,
                                         "input [gpu] unknown\n");
        }
-       pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data);
+       pr_err("alienware-wmi: unknown HDMI source status: %u\n", status);
        return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n");
 }