lockref: use bool for false/true returns

Replace int used as bool with the actual bool type for return values that
can only be true or false.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20250115094702.504610-4-hch@lst.de
Signed-off-by: Christian Brauner <brauner@kernel.org>

diff --git a/include/linux/lockref.h b/include/linux/lockref.h
index e5aa0347f274b59ddf23f8c292cf23141877895f..3d770e1bdbad6298f04670a14b54238785e77690 100644 (file)
--- a/include/linux/lockref.h
+++ b/include/linux/lockref.h
@@ -36,11 +36,11 @@ struct lockref {
 
 extern void lockref_get(struct lockref *);
 extern int lockref_put_return(struct lockref *);
-extern int lockref_get_not_zero(struct lockref *);
-extern int lockref_put_or_lock(struct lockref *);
+bool lockref_get_not_zero(struct lockref *lockref);
+bool lockref_put_or_lock(struct lockref *lockref);
 
 extern void lockref_mark_dead(struct lockref *);
-extern int lockref_get_not_dead(struct lockref *);
+bool lockref_get_not_dead(struct lockref *lockref);
 
 /* Must be called under spinlock for reliable results */
 static inline bool __lockref_is_dead(const struct lockref *l)

diff --git a/lib/lockref.c b/lib/lockref.c
index b1b042a9a6c8e2b625ec2905eaa716999e2154e9..5d8e3ef3860ee1290dbde1d01edb6f992b60fac5 100644 (file)
--- a/lib/lockref.c
+++ b/lib/lockref.c
@@ -58,23 +58,22 @@ EXPORT_SYMBOL(lockref_get);
  * @lockref: pointer to lockref structure
  * Return: 1 if count updated successfully or 0 if count was zero
  */
-int lockref_get_not_zero(struct lockref *lockref)
+bool lockref_get_not_zero(struct lockref *lockref)
 {
-       int retval;
+       bool retval = false;
 
        CMPXCHG_LOOP(
                new.count++;
                if (old.count <= 0)
-                       return 0;
+                       return false;
        ,
-               return 1;
+               return true;
        );
 
        spin_lock(&lockref->lock);
-       retval = 0;
        if (lockref->count > 0) {
                lockref->count++;
-               retval = 1;
+               retval = true;
        }
        spin_unlock(&lockref->lock);
        return retval;
@@ -106,22 +105,22 @@ EXPORT_SYMBOL(lockref_put_return);
  * @lockref: pointer to lockref structure
  * Return: 1 if count updated successfully or 0 if count <= 1 and lock taken
  */
-int lockref_put_or_lock(struct lockref *lockref)
+bool lockref_put_or_lock(struct lockref *lockref)
 {
        CMPXCHG_LOOP(
                new.count--;
                if (old.count <= 1)
                        break;
        ,
-               return 1;
+               return true;
        );
 
        spin_lock(&lockref->lock);
        if (lockref->count <= 1)
-               return 0;
+               return false;
        lockref->count--;
        spin_unlock(&lockref->lock);
-       return 1;
+       return true;
 }
 EXPORT_SYMBOL(lockref_put_or_lock);
 
@@ -141,23 +140,22 @@ EXPORT_SYMBOL(lockref_mark_dead);
  * @lockref: pointer to lockref structure
  * Return: 1 if count updated successfully or 0 if lockref was dead
  */
-int lockref_get_not_dead(struct lockref *lockref)
+bool lockref_get_not_dead(struct lockref *lockref)
 {
-       int retval;
+       bool retval = false;
 
        CMPXCHG_LOOP(
                new.count++;
                if (old.count < 0)
-                       return 0;
+                       return false;
        ,
-               return 1;
+               return true;
        );
 
        spin_lock(&lockref->lock);
-       retval = 0;
        if (lockref->count >= 0) {
                lockref->count++;
-               retval = 1;
+               retval = true;
        }
        spin_unlock(&lockref->lock);
        return retval;