]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
Revert "sd-netlink: prepare buffer for dropping unexpected message"
authorLennart Poettering <lennart@poettering.net>
Thu, 17 Apr 2025 06:15:11 +0000 (08:15 +0200)
committerLennart Poettering <lennart@poettering.net>
Thu, 17 Apr 2025 06:25:40 +0000 (08:25 +0200)
This reverts commit bf478dcffbc3c568fb3a3c8e8b93b3e7b66f4228.

I think we should avoid allocating memory needlessly just to free it
again, in particular if this can be triggered by some rogue peer.

src/libsystemd/sd-netlink/netlink-socket.c

index 5959959f4271c2c66ea14051451dc2bf930bc3ca..9d2b3984c2b11dd6271a7e3995e6b57d32816c5f 100644 (file)
@@ -181,12 +181,6 @@ static int socket_recv_message(int fd, void *buf, size_t buf_size, uint32_t *ret
                 log_debug("sd-netlink: ignoring message from PID %"PRIu32, sender.nl.nl_pid);
 
                 if (peek) {
-                        _cleanup_free_ uint8_t *b = new(uint8_t, n);
-                        if (!b)
-                                return -ENOMEM;
-
-                        iov = IOVEC_MAKE(b, n);
-
                         /* drop the message */
                         n = recvmsg_safe(fd, &msg, 0);
                         if (n < 0)