]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
f2fs: Fix __write_node_folio() conversion
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Sun, 1 Jun 2025 00:26:54 +0000 (01:26 +0100)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 10 Jun 2025 14:52:21 +0000 (14:52 +0000)
This conversion moved the folio_unlock() to inside __write_node_folio(),
but missed one caller so we had a double-unlock on this path.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Chao Yu <chao@kernel.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Reported-by: syzbot+c0dc46208750f063d0e0@syzkaller.appspotmail.com
Fixes: 80f31d2a7e5f (f2fs: return bool from __write_node_folio)
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/node.c

index 1cb4cba7f961b969f64048a7d059ab36d1271290..bfe104db284ef1006e0d4d84dc2461826fb58834 100644 (file)
@@ -2078,7 +2078,6 @@ write_node:
 
                        if (!__write_node_folio(folio, false, &submitted,
                                        wbc, do_balance, io_type, NULL)) {
-                               folio_unlock(folio);
                                folio_batch_release(&fbatch);
                                ret = -EIO;
                                goto out;