]> git.ipfire.org Git - thirdparty/git.git/commitdiff
git-prompt: fix uninitialized variable
authorAvi Halachmi (:avih) <avihpit@yahoo.com>
Tue, 20 Aug 2024 01:48:26 +0000 (01:48 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 20 Aug 2024 15:28:17 +0000 (08:28 -0700)
First use is in the form:  local var; ...; var=$var$whatever...

If the variable was unset (as bash and others do after "local x"),
then it would error if set -u is in effect.

Also, many shells inherit the existing value after "local var"
without init, but in this case it's unlikely to have a prior value.

Now we initialize it.

(local var= is enough, but local var="" is the custom in this file)

Signed-off-by: Avi Halachmi (:avih) <avihpit@yahoo.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/completion/git-prompt.sh

index ebf2e30d68465806c748987aa36f9a50a99eae95..4cc2cf91bb686a732db6a51c6f5e3f17020b7aee 100644 (file)
@@ -116,7 +116,7 @@ printf -v __git_printf_supports_v -- '%s' yes >/dev/null 2>&1
 __git_ps1_show_upstream ()
 {
        local key value
-       local svn_remote svn_url_pattern count n
+       local svn_remote svn_url_pattern="" count n
        local upstream_type=git legacy="" verbose="" name=""
 
        svn_remote=()