iommu/arm-smmu-v3: Document SVA interaction with new pagetable features

Process pagetables may now be using new permission-indirection-based
features which an SMMU may not understand when given such a table for
SVA. Although SMMUv3.4 does add its own S1PIE feature, realistically
we're still going to have to cope with feature mismatches between CPUs
and SMMUs, so let's start simple and essentially just document the
expectations for what falls out as-is. Although it seems unlikely for
SVA applications to also depend on memory-hardening features, or
vice-versa, the relative lifecycles make it tricky to enforce mutual
exclusivity. Thankfully our PIE index allocation makes it relatively
benign for an SMMU to keep interpreting them as direct permissions, the
only real implication is that an SVA application cannot harden itself
against its own devices with these features. Thus, inform the user about
that just in case they have other expectations.

Also we don't (yet) support LPA2, so deny SVA entirely if we're going to
misunderstand the pagetable format altogether.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/68a37b00a720f0827cac0e4f40e4d3a688924054.1733406275.git.robin.murphy@arm.com
Signed-off-by: Will Deacon <will@kernel.org>

diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c
index 1d3e7156977565d86018a4d090645f9b629da34d..9ba596430e7cf9b0e67498a06f5b8f58021dfbb4 100644 (file)
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c
@@ -112,6 +112,15 @@ void arm_smmu_make_sva_cd(struct arm_smmu_cd *target,
         * from the current CPU register
         */
        target->data[3] = cpu_to_le64(read_sysreg(mair_el1));
+
+       /*
+        * Note that we don't bother with S1PIE on the SMMU, we just rely on
+        * our default encoding scheme matching direct permissions anyway.
+        * SMMU has no notion of S1POE nor GCS, so make sure that is clear if
+        * either is enabled for CPUs, just in case anyone imagines otherwise.
+        */
+       if (system_supports_poe() || system_supports_gcs())
+               dev_warn_once(master->smmu->dev, "SVA devices ignore permission overlays and GCS\n");
 }
 EXPORT_SYMBOL_IF_KUNIT(arm_smmu_make_sva_cd);
 
@@ -206,8 +215,12 @@ bool arm_smmu_sva_supported(struct arm_smmu_device *smmu)
        unsigned long asid_bits;
        u32 feat_mask = ARM_SMMU_FEAT_COHERENCY;
 
-       if (vabits_actual == 52)
+       if (vabits_actual == 52) {
+               /* We don't support LPA2 */
+               if (PAGE_SIZE != SZ_64K)
+                       return false;
                feat_mask |= ARM_SMMU_FEAT_VAX;
+       }
 
        if ((smmu->features & feat_mask) != feat_mask)
                return false;