]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: arcnet: Do not call kfree_skb() under local_irq_disable()
authorJinjie Ruan <ruanjinjie@huawei.com>
Thu, 24 Aug 2023 06:43:36 +0000 (14:43 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Sep 2023 08:46:55 +0000 (10:46 +0200)
[ Upstream commit 786c96e92fb9e854cb8b0cb7399bb2fb28e15c4b ]

It is not allowed to call kfree_skb() from hardware interrupt
context or with hardware interrupts being disabled.
So replace kfree_skb() with dev_kfree_skb_irq() under
local_irq_disable(). Compile tested only.

Fixes: 05fcd31cc472 ("arcnet: add err_skb package for package status feedback")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/arcnet/arcnet.c

index 998bc7bc7d1f0bbe560bf8af8a7c5a26aa2f4a6d..0f02d2b3438f2b0d6257c7e8c7ce58293bbcca0b 100644 (file)
@@ -433,7 +433,7 @@ static void arcnet_reply_tasklet(unsigned long data)
 
        ret = sock_queue_err_skb(sk, ackskb);
        if (ret)
-               kfree_skb(ackskb);
+               dev_kfree_skb_irq(ackskb);
 
        local_irq_enable();
 };