]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ice: Do not set LB_EN for prune switch rules
authorChristopher N Bednarz <christopher.n.bednarz@intel.com>
Wed, 27 Feb 2019 00:35:16 +0000 (16:35 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Jun 2019 09:53:05 +0000 (11:53 +0200)
[ Upstream commit b58dafbc6f1089942c1e74b8ab9c616fe06dbfac ]

LB_EN for prune switch rules was causing all TX traffic
to loopback to the internal switch and dropped.  When
running bi-directional stress workloads with RDMA
the RDPU would hang blocking tx and rx traffic.

Signed-off-by: Christopher N Bednarz <christopher.n.bednarz@intel.com>
Reviewed-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/intel/ice/ice_switch.c

index e40d5f34d59db09ce3dfdcb6dfea1e5aaa25ed5d..c5f6cfecc0421a0106e1f4b45227102df310f7d9 100644 (file)
@@ -643,7 +643,12 @@ static void ice_fill_sw_info(struct ice_hw *hw, struct ice_fltr_info *fi)
             fi->fltr_act == ICE_FWD_TO_VSI_LIST ||
             fi->fltr_act == ICE_FWD_TO_Q ||
             fi->fltr_act == ICE_FWD_TO_QGRP)) {
-               fi->lb_en = true;
+               /* Setting LB for prune actions will result in replicated
+                * packets to the internal switch that will be dropped.
+                */
+               if (fi->lkup_type != ICE_SW_LKUP_VLAN)
+                       fi->lb_en = true;
+
                /* Set lan_en to TRUE if
                 * 1. The switch is a VEB AND
                 * 2