]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: ethernet: sis900: Use pure PCI devres API
authorPhilipp Stanner <phasta@kernel.org>
Fri, 25 Apr 2025 08:57:38 +0000 (10:57 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 28 Apr 2025 23:19:16 +0000 (16:19 -0700)
The currently used function pci_request_regions() is one of the
problematic "hybrid devres" PCI functions, which are sometimes managed
through devres, and sometimes not (depending on whether
pci_enable_device() or pcim_enable_device() has been called before).

The PCI subsystem wants to remove this behavior and, therefore, needs to
port all users to functions that don't have this problem.

Replace pci_request_regions() with pcim_request_all_regions().

Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Daniele Venzano <venza@brownhat.org>
Link: https://patch.msgid.link/20250425085740.65304-7-phasta@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sis/sis900.c

index 332cbd72590094d2b7accfee296c8132539bf873..df869f82cae8a28650cef1a2ddc3f6ca57006cab 100644 (file)
@@ -468,7 +468,7 @@ static int sis900_probe(struct pci_dev *pci_dev,
        SET_NETDEV_DEV(net_dev, &pci_dev->dev);
 
        /* We do a request_region() to register /proc/ioports info. */
-       ret = pci_request_regions(pci_dev, "sis900");
+       ret = pcim_request_all_regions(pci_dev, "sis900");
        if (ret)
                goto err_out;