]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Nov 2019 07:58:12 +0000 (08:58 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Nov 2019 07:58:12 +0000 (08:58 +0100)
added patches:
arm64-fix-for-bad_mode-handler-to-always-result-in-panic.patch
cpufreq-skip-cpufreq-resume-if-it-s-not-suspended.patch
dm-use-blk_set_queue_dying-in-__dm_destroy.patch
mmc-block-fix-tag-condition-with-packed-writes.patch
ocfs2-remove-ocfs2_is_o2cb_active.patch

queue-4.4/arm64-fix-for-bad_mode-handler-to-always-result-in-panic.patch [new file with mode: 0644]
queue-4.4/cpufreq-skip-cpufreq-resume-if-it-s-not-suspended.patch [new file with mode: 0644]
queue-4.4/dm-use-blk_set_queue_dying-in-__dm_destroy.patch [new file with mode: 0644]
queue-4.4/mmc-block-fix-tag-condition-with-packed-writes.patch [new file with mode: 0644]
queue-4.4/ocfs2-remove-ocfs2_is_o2cb_active.patch [new file with mode: 0644]
queue-4.4/series

diff --git a/queue-4.4/arm64-fix-for-bad_mode-handler-to-always-result-in-panic.patch b/queue-4.4/arm64-fix-for-bad_mode-handler-to-always-result-in-panic.patch
new file mode 100644 (file)
index 0000000..0b5885b
--- /dev/null
@@ -0,0 +1,37 @@
+From e4ba15debcfd27f60d43da940a58108783bff2a6 Mon Sep 17 00:00:00 2001
+From: Hari Vyas <hari.vyas@broadcom.com>
+Date: Tue, 7 Aug 2018 16:33:48 +0530
+Subject: arm64: fix for bad_mode() handler to always result in panic
+
+From: Hari Vyas <hari.vyas@broadcom.com>
+
+commit e4ba15debcfd27f60d43da940a58108783bff2a6 upstream.
+
+The bad_mode() handler is called if we encounter an uunknown exception,
+with the expectation that the subsequent call to panic() will halt the
+system. Unfortunately, if the exception calling bad_mode() is taken from
+EL0, then the call to die() can end up killing the current user task and
+calling schedule() instead of falling through to panic().
+
+Remove the die() call altogether, since we really want to bring down the
+machine in this "impossible" case.
+
+Signed-off-by: Hari Vyas <hari.vyas@broadcom.com>
+Signed-off-by: Will Deacon <will.deacon@arm.com>
+Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
+Signed-off-by: Lee Jones <lee.jones@linaro.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ arch/arm64/kernel/traps.c |    1 -
+ 1 file changed, 1 deletion(-)
+
+--- a/arch/arm64/kernel/traps.c
++++ b/arch/arm64/kernel/traps.c
+@@ -448,7 +448,6 @@ asmlinkage void bad_mode(struct pt_regs
+       pr_crit("Bad mode in %s handler detected, code 0x%08x -- %s\n",
+               handler[reason], esr, esr_get_class_string(esr));
+-      die("Oops - bad mode", regs, 0);
+       local_irq_disable();
+       panic("bad mode");
+ }
diff --git a/queue-4.4/cpufreq-skip-cpufreq-resume-if-it-s-not-suspended.patch b/queue-4.4/cpufreq-skip-cpufreq-resume-if-it-s-not-suspended.patch
new file mode 100644 (file)
index 0000000..f3f86ae
--- /dev/null
@@ -0,0 +1,65 @@
+From 703cbaa601ff3fb554d1246c336ba727cc083ea0 Mon Sep 17 00:00:00 2001
+From: Bo Yan <byan@nvidia.com>
+Date: Tue, 23 Jan 2018 13:57:55 -0800
+Subject: cpufreq: Skip cpufreq resume if it's not suspended
+
+From: Bo Yan <byan@nvidia.com>
+
+commit 703cbaa601ff3fb554d1246c336ba727cc083ea0 upstream.
+
+cpufreq_resume can be called even without preceding cpufreq_suspend.
+This can happen in following scenario:
+
+    suspend_devices_and_enter
+       --> dpm_suspend_start
+          --> dpm_prepare
+              --> device_prepare : this function errors out
+          --> dpm_suspend: this is skipped due to dpm_prepare failure
+                           this means cpufreq_suspend is skipped over
+       --> goto Recover_platform, due to previous error
+       --> goto Resume_devices
+       --> dpm_resume_end
+           --> dpm_resume
+               --> cpufreq_resume
+
+In case schedutil is used as frequency governor, cpufreq_resume will
+eventually call sugov_start, which does following:
+
+    memset(sg_cpu, 0, sizeof(*sg_cpu));
+    ....
+
+This effectively erases function pointer for frequency update, causing
+crash later on. The function pointer would have been set correctly if
+subsequent cpufreq_add_update_util_hook runs successfully, but that
+function returns earlier because cpufreq_suspend was not called:
+
+    if (WARN_ON(per_cpu(cpufreq_update_util_data, cpu)))
+               return;
+
+The fix is to check cpufreq_suspended first, if it's false, that means
+cpufreq_suspend was not called in the first place, so do not resume
+cpufreq.
+
+Signed-off-by: Bo Yan <byan@nvidia.com>
+Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
+[ rjw: Dropped printing a message ]
+Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
+Signed-off-by: Lee Jones <lee.jones@linaro.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/cpufreq/cpufreq.c |    3 +++
+ 1 file changed, 3 insertions(+)
+
+--- a/drivers/cpufreq/cpufreq.c
++++ b/drivers/cpufreq/cpufreq.c
+@@ -1627,6 +1627,9 @@ void cpufreq_resume(void)
+       if (!cpufreq_driver)
+               return;
++      if (unlikely(!cpufreq_suspended))
++              return;
++
+       cpufreq_suspended = false;
+       if (!has_target())
diff --git a/queue-4.4/dm-use-blk_set_queue_dying-in-__dm_destroy.patch b/queue-4.4/dm-use-blk_set_queue_dying-in-__dm_destroy.patch
new file mode 100644 (file)
index 0000000..75b5037
--- /dev/null
@@ -0,0 +1,36 @@
+From 2e91c3694181dc500faffec16c5aaa0ac5e15449 Mon Sep 17 00:00:00 2001
+From: Bart Van Assche <bart.vanassche@sandisk.com>
+Date: Fri, 18 Nov 2016 14:26:47 -0800
+Subject: dm: use blk_set_queue_dying() in __dm_destroy()
+
+From: Bart Van Assche <bart.vanassche@sandisk.com>
+
+commit 2e91c3694181dc500faffec16c5aaa0ac5e15449 upstream.
+
+After QUEUE_FLAG_DYING has been set any code that is waiting in
+get_request() should be woken up.  But to get this behaviour
+blk_set_queue_dying() must be used instead of only setting
+QUEUE_FLAG_DYING.
+
+Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
+Signed-off-by: Mike Snitzer <snitzer@redhat.com>
+Signed-off-by: Lee Jones <lee.jones@linaro.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/md/dm.c |    4 +---
+ 1 file changed, 1 insertion(+), 3 deletions(-)
+
+--- a/drivers/md/dm.c
++++ b/drivers/md/dm.c
+@@ -2939,9 +2939,7 @@ static void __dm_destroy(struct mapped_d
+       set_bit(DMF_FREEING, &md->flags);
+       spin_unlock(&_minor_lock);
+-      spin_lock_irq(q->queue_lock);
+-      queue_flag_set(QUEUE_FLAG_DYING, q);
+-      spin_unlock_irq(q->queue_lock);
++      blk_set_queue_dying(q);
+       if (dm_request_based(md) && md->kworker_task)
+               flush_kthread_worker(&md->kworker);
diff --git a/queue-4.4/mmc-block-fix-tag-condition-with-packed-writes.patch b/queue-4.4/mmc-block-fix-tag-condition-with-packed-writes.patch
new file mode 100644 (file)
index 0000000..06f4d5f
--- /dev/null
@@ -0,0 +1,34 @@
+From d806b46e5f496a6335ebd7f8432d2533507ce9a2 Mon Sep 17 00:00:00 2001
+From: Adrian Hunter <adrian.hunter@intel.com>
+Date: Fri, 10 Jun 2016 16:22:16 +0300
+Subject: mmc: block: Fix tag condition with packed writes
+
+From: Adrian Hunter <adrian.hunter@intel.com>
+
+commit d806b46e5f496a6335ebd7f8432d2533507ce9a2 upstream.
+
+Apparently a cut-and-paste error, 'do_data_tag' is using 'brq' for data
+size even though 'brq' has not been set up. Instead use blk_rq_sectors().
+
+Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
+Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
+Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
+Signed-off-by: Lee Jones <lee.jones@linaro.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/mmc/card/block.c |    3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+--- a/drivers/mmc/card/block.c
++++ b/drivers/mmc/card/block.c
+@@ -1772,8 +1772,7 @@ static void mmc_blk_packed_hdr_wrq_prep(
+               do_data_tag = (card->ext_csd.data_tag_unit_size) &&
+                       (prq->cmd_flags & REQ_META) &&
+                       (rq_data_dir(prq) == WRITE) &&
+-                      ((brq->data.blocks * brq->data.blksz) >=
+-                       card->ext_csd.data_tag_unit_size);
++                      blk_rq_bytes(prq) >= card->ext_csd.data_tag_unit_size;
+               /* Argument of CMD23 */
+               packed_cmd_hdr[(i * 2)] = cpu_to_le32(
+                       (do_rel_wr ? MMC_CMD23_ARG_REL_WR : 0) |
diff --git a/queue-4.4/ocfs2-remove-ocfs2_is_o2cb_active.patch b/queue-4.4/ocfs2-remove-ocfs2_is_o2cb_active.patch
new file mode 100644 (file)
index 0000000..d4fb0c5
--- /dev/null
@@ -0,0 +1,71 @@
+From a634644751c46238df58bbfe992e30c1668388db Mon Sep 17 00:00:00 2001
+From: Gang He <ghe@suse.com>
+Date: Fri, 2 Nov 2018 15:48:03 -0700
+Subject: ocfs2: remove ocfs2_is_o2cb_active()
+
+From: Gang He <ghe@suse.com>
+
+commit a634644751c46238df58bbfe992e30c1668388db upstream.
+
+Remove ocfs2_is_o2cb_active().  We have similar functions to identify
+which cluster stack is being used via osb->osb_cluster_stack.
+
+Secondly, the current implementation of ocfs2_is_o2cb_active() is not
+totally safe.  Based on the design of stackglue, we need to get
+ocfs2_stack_lock before using ocfs2_stack related data structures, and
+that active_stack pointer can be NULL in the case of mount failure.
+
+Link: http://lkml.kernel.org/r/1495441079-11708-1-git-send-email-ghe@suse.com
+Signed-off-by: Gang He <ghe@suse.com>
+Reviewed-by: Joseph Qi <jiangqi903@gmail.com>
+Reviewed-by: Eric Ren <zren@suse.com>
+Acked-by: Changwei Ge <ge.changwei@h3c.com>
+Cc: Mark Fasheh <mark@fasheh.com>
+Cc: Joel Becker <jlbec@evilplan.org>
+Cc: Junxiao Bi <junxiao.bi@oracle.com>
+Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
+Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
+Signed-off-by: Lee Jones <lee.jones@linaro.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ fs/ocfs2/dlmglue.c   |    2 +-
+ fs/ocfs2/stackglue.c |    6 ------
+ fs/ocfs2/stackglue.h |    3 ---
+ 3 files changed, 1 insertion(+), 10 deletions(-)
+
+--- a/fs/ocfs2/dlmglue.c
++++ b/fs/ocfs2/dlmglue.c
+@@ -3426,7 +3426,7 @@ static int ocfs2_downconvert_lock(struct
+        * we can recover correctly from node failure. Otherwise, we may get
+        * invalid LVB in LKB, but without DLM_SBF_VALNOTVALID being set.
+        */
+-      if (!ocfs2_is_o2cb_active() &&
++      if (ocfs2_userspace_stack(osb) &&
+           lockres->l_ops->flags & LOCK_TYPE_USES_LVB)
+               lvb = 1;
+--- a/fs/ocfs2/stackglue.c
++++ b/fs/ocfs2/stackglue.c
+@@ -48,12 +48,6 @@ static char ocfs2_hb_ctl_path[OCFS2_MAX_
+  */
+ static struct ocfs2_stack_plugin *active_stack;
+-inline int ocfs2_is_o2cb_active(void)
+-{
+-      return !strcmp(active_stack->sp_name, OCFS2_STACK_PLUGIN_O2CB);
+-}
+-EXPORT_SYMBOL_GPL(ocfs2_is_o2cb_active);
+-
+ static struct ocfs2_stack_plugin *ocfs2_stack_lookup(const char *name)
+ {
+       struct ocfs2_stack_plugin *p;
+--- a/fs/ocfs2/stackglue.h
++++ b/fs/ocfs2/stackglue.h
+@@ -298,7 +298,4 @@ void ocfs2_stack_glue_set_max_proto_vers
+ int ocfs2_stack_glue_register(struct ocfs2_stack_plugin *plugin);
+ void ocfs2_stack_glue_unregister(struct ocfs2_stack_plugin *plugin);
+-/* In ocfs2_downconvert_lock(), we need to know which stack we are using */
+-int ocfs2_is_o2cb_active(void);
+-
+ #endif  /* STACKGLUE_H */
index 588169960fba45a4e932a9c6c0f9f209e75bac89..62d66f23b34583f56a31c4024f66e89cc6635350 100644 (file)
@@ -98,3 +98,8 @@ spi-omap2-mcspi-fix-dma-and-fifo-event-trigger-size-.patch
 ib-hfi1-ensure-full-gen3-speed-in-a-gen4-system.patch
 bluetooth-fix-invalid-free-in-bcsp_close.patch
 ath9k_hw-fix-uninitialized-variable-data.patch
+dm-use-blk_set_queue_dying-in-__dm_destroy.patch
+arm64-fix-for-bad_mode-handler-to-always-result-in-panic.patch
+cpufreq-skip-cpufreq-resume-if-it-s-not-suspended.patch
+ocfs2-remove-ocfs2_is_o2cb_active.patch
+mmc-block-fix-tag-condition-with-packed-writes.patch