]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Oct 2022 10:13:23 +0000 (12:13 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Oct 2022 10:13:23 +0000 (12:13 +0200)
added patches:
alsa-usb-audio-fix-last-interface-check-for-registration.patch
net-ieee802154-return-einval-for-unknown-addr-type.patch

queue-5.19/alsa-usb-audio-fix-last-interface-check-for-registration.patch [new file with mode: 0644]
queue-5.19/net-ieee802154-return-einval-for-unknown-addr-type.patch [new file with mode: 0644]
queue-5.19/series

diff --git a/queue-5.19/alsa-usb-audio-fix-last-interface-check-for-registration.patch b/queue-5.19/alsa-usb-audio-fix-last-interface-check-for-registration.patch
new file mode 100644 (file)
index 0000000..bf7eb23
--- /dev/null
@@ -0,0 +1,40 @@
+From 39efc9c8a973ddff5918191525d1679d0fb368ea Mon Sep 17 00:00:00 2001
+From: Takashi Iwai <tiwai@suse.de>
+Date: Thu, 15 Sep 2022 10:59:47 +0200
+Subject: ALSA: usb-audio: Fix last interface check for registration
+
+From: Takashi Iwai <tiwai@suse.de>
+
+commit 39efc9c8a973ddff5918191525d1679d0fb368ea upstream.
+
+The recent fix in commit 6392dcd1d0c7 ("ALSA: usb-audio: Register card
+at the last interface") tried to delay the card registration until the
+last found interface is probed.  It assumed that the probe callback
+gets called for those later interfaces, but it's not always true; as
+the driver loops over the descriptor and probes the matching ones,
+it's not separately called via multiple probe calls.  This results in
+the missing card registration, i.e. no sound device.
+
+For addressing this problem, replace the check whether the last
+interface is processed with usb_interface_claimed() instead of the
+comparison with the probe interface number.
+
+Fixes: 6392dcd1d0c7 ("ALSA: usb-audio: Register card at the last interface")
+Link: https://lore.kernel.org/r/20220915085947.7922-1-tiwai@suse.de
+Signed-off-by: Takashi Iwai <tiwai@suse.de>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ sound/usb/card.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/sound/usb/card.c
++++ b/sound/usb/card.c
+@@ -884,7 +884,7 @@ static int usb_audio_probe(struct usb_in
+        * one given via option
+        */
+       if (check_delayed_register_option(chip) == ifnum ||
+-          chip->last_iface == ifnum) {
++          usb_interface_claimed(usb_ifnum_to_if(dev, chip->last_iface))) {
+               err = snd_card_register(chip->card);
+               if (err < 0)
+                       goto __error;
diff --git a/queue-5.19/net-ieee802154-return-einval-for-unknown-addr-type.patch b/queue-5.19/net-ieee802154-return-einval-for-unknown-addr-type.patch
new file mode 100644 (file)
index 0000000..47c874a
--- /dev/null
@@ -0,0 +1,54 @@
+From 30393181fdbc1608cc683b4ee99dcce05ffcc8c7 Mon Sep 17 00:00:00 2001
+From: Alexander Aring <aahringo@redhat.com>
+Date: Wed, 5 Oct 2022 22:02:37 -0400
+Subject: net: ieee802154: return -EINVAL for unknown addr type
+
+From: Alexander Aring <aahringo@redhat.com>
+
+commit 30393181fdbc1608cc683b4ee99dcce05ffcc8c7 upstream.
+
+This patch adds handling to return -EINVAL for an unknown addr type. The
+current behaviour is to return 0 as successful but the size of an
+unknown addr type is not defined and should return an error like -EINVAL.
+
+Fixes: 94160108a70c ("net/ieee802154: fix uninit value bug in dgram_sendmsg")
+Signed-off-by: Alexander Aring <aahringo@redhat.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ include/net/ieee802154_netdev.h |   12 +++++++++---
+ 1 file changed, 9 insertions(+), 3 deletions(-)
+
+--- a/include/net/ieee802154_netdev.h
++++ b/include/net/ieee802154_netdev.h
+@@ -185,21 +185,27 @@ static inline int
+ ieee802154_sockaddr_check_size(struct sockaddr_ieee802154 *daddr, int len)
+ {
+       struct ieee802154_addr_sa *sa;
++      int ret = 0;
+       sa = &daddr->addr;
+       if (len < IEEE802154_MIN_NAMELEN)
+               return -EINVAL;
+       switch (sa->addr_type) {
++      case IEEE802154_ADDR_NONE:
++              break;
+       case IEEE802154_ADDR_SHORT:
+               if (len < IEEE802154_NAMELEN_SHORT)
+-                      return -EINVAL;
++                      ret = -EINVAL;
+               break;
+       case IEEE802154_ADDR_LONG:
+               if (len < IEEE802154_NAMELEN_LONG)
+-                      return -EINVAL;
++                      ret = -EINVAL;
++              break;
++      default:
++              ret = -EINVAL;
+               break;
+       }
+-      return 0;
++      return ret;
+ }
+ static inline void ieee802154_addr_from_sa(struct ieee802154_addr *a,
index 9537adf6f1afc19f0da7edefc59061b7e57a5f11..e65e564ef82ce557d1c2d3e4975048b549a3a883 100644 (file)
@@ -826,3 +826,5 @@ perf-skip-and-warn-on-unknown-format-confign-attrs.patch
 perf-intel-pt-fix-segfault-in-intel_pt_print_info-with-uclibc.patch
 perf-intel-pt-fix-system_wide-dummy-event-for-hybrid.patch
 mm-hugetlb-fix-uaf-in-hugetlb_handle_userfault.patch
+net-ieee802154-return-einval-for-unknown-addr-type.patch
+alsa-usb-audio-fix-last-interface-check-for-registration.patch