arm64: dts: rockchip: Use default-state for power LED for Radxa boards

Currently, on Radxa boards, the power LED is turned on immediately
after power-up, independent of software control. The heartbeat LED and
other available LEDs are subsequently turned on by the initial
software, such as U-Boot, to indicate software is running.

However, the device tree description for this behavior is inconsistent
and fragmented, with definitions split between the main Linux DTS
files and separate U-Boot files (u-boot/arch/arm/dts/*-u-boot.dtsi).

This patch addresses the inconsistency for the power LED by using
default-state = "on" instead of linux,default-trigger = "default-on".

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Link: https://patch.msgid.link/20251113124222.4691-2-naoki@radxa.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>

diff --git a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
index 7a32972bc24965ed1592b32ef84a6f67de5fd8de..c1e3098b9a7bcf44633ff59d71f1ad487b7f8d50 100644 (file)
--- a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
@@ -35,7 +35,6 @@
                        function = LED_FUNCTION_POWER;
                        gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
                        label = "rockpis:green:power";
-                       linux,default-trigger = "default-on";
                };
 
                blue-led {

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts
index 962b8b231c96036b00ef6697db3beee6236fe3bd..74160cf891885f5c816540f5c30452dabb4abd21 100644 (file)
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts
@@ -39,8 +39,8 @@
                led-0 {
                        function = LED_FUNCTION_POWER;
                        color = <LED_COLOR_ID_GREEN>;
+                       default-state = "on";
                        gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_LOW>;
-                       linux,default-trigger = "default-on";
                };
 
                /* USER_LED2 */

diff --git a/arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts b/arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts
index c03ae1dd34560b5c34346e7b5e39695372c91ee6..0b696d49b71fa3ede70daf6ce454c26fd47cb1f4 100644 (file)
--- a/arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts
@@ -45,7 +45,6 @@
                default-state = "on";
                function = LED_FUNCTION_STATUS;
                gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_LOW>;
-               linux,default-trigger = "default-on";
        };
 };
 

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts
index 9bc33422ced5017a7c7a9788919838fd72c9626e..7023dc326d0e81bf7f01a690829ad2948e0db40e 100644 (file)
--- a/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts
@@ -52,9 +52,9 @@
 
                power-led {
                        color = <LED_COLOR_ID_GREEN>;
+                       default-state = "on";
                        function = LED_FUNCTION_STATUS;
                        gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_HIGH>;
-                       linux,default-trigger = "default-on";
                };
 
                user-led {

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
index 63f3d286c5d11d2d0e4a86f2abd592f123ec08ee..172aeabba72a592fd97dfade3603096e545270be 100644 (file)
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
@@ -88,8 +88,8 @@
                pinctrl-0 = <&led_pins>;
 
                power-led1 {
+                       default-state = "on";
                        gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>;
-                       linux,default-trigger = "default-on";
                };
 
                hdd-led2 {

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
index c1e03b99a00fbe37a1dc66c471858a8af66cd11f..045a853d39ec757dd83003ccaef072fab873559f 100644 (file)
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
@@ -61,9 +61,9 @@
 
                power-led {
                        color = <LED_COLOR_ID_GREEN>;
+                       default-state = "on";
                        function = LED_FUNCTION_POWER;
                        gpios = <&gpio3 RK_PC4 GPIO_ACTIVE_HIGH>;
-                       linux,default-trigger = "default-on";
                };
        };